Feature/replace deprecated container call #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarld
requested changes
Nov 26, 2021
|
Test for PHP 7.4 8.0 and 8.1 fail. info: First run after 5.4 is stable. I guess these should be handled in an different PR. WDYT? |
|
Yes indeed. Let's do that! |
|
Here we are: #68 |
Closed
…iner-call' into feature/replace-deprecated-container-call
|
@mtarld Could you please aprove the workflow to run the github action tests. I guess i did the rebase wrong. Sorry for that. |
|
Thank you @Chris53897! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Proof of concept for my (thats another account from me) idea in #65
A lot of code changes just to support symfony 4.4 :(
It works according to the test pipeline.
I don't have PHP 7.1 on my pc to verify it local.
If you find a simpler and better solution i would be glad.
Greetz