From d9a5a207e10209eecef8ed02289824a8630ed67d Mon Sep 17 00:00:00 2001 From: Chavez Date: Mon, 25 Jul 2016 10:03:49 -0700 Subject: [PATCH] Project#envvar method naming fix * Fix from plural envvar to envvars for consistency with API endpoint * Preserve old functionality --- lib/circleci/project.rb | 11 ++++++++++- spec/circleci/project_spec.rb | 10 +++++++--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/lib/circleci/project.rb b/lib/circleci/project.rb index 14ac960..c62faf3 100644 --- a/lib/circleci/project.rb +++ b/lib/circleci/project.rb @@ -102,10 +102,19 @@ def self.enable(username, project) # @param project [String] - Name of project # @return [CircleCi::Response] - Response object - def self.envvars(username, project) + def self.envvar(username, project) CircleCi.http.get "/project/#{username}/#{project}/envvar" end + ## + # + # @deprecated Please use [CircleCi::Project#envvar] + def self.envvars(username, project) + logger = Logger.new(STDOUT) + logger.warn('[Deprecated] Project#envvars is deprecated please use Project#envvar') + envvar username, project + end + ## # # Sets an envvar for a project diff --git a/spec/circleci/project_spec.rb b/spec/circleci/project_spec.rb index 0b3ed34..fd9da27 100644 --- a/spec/circleci/project_spec.rb +++ b/spec/circleci/project_spec.rb @@ -402,9 +402,9 @@ end end - describe 'envvars' do + describe 'envvar' do context 'successfully', vcr: { cassette_name: 'project/envvar/success', record: :none } do - let(:res) { CircleCi::Project.envvars 'mtchavez', 'circleci' } + let(:res) { CircleCi::Project.envvar 'mtchavez', 'circleci' } it 'returns a response object' do res.should be_an_instance_of(CircleCi::Response) @@ -420,7 +420,7 @@ end context 'unsuccessfully', vcr: { cassette_name: 'project/envvar/unsuccessfully', record: :none } do - let(:res) { CircleCi::Project.envvars 'mtchavez', 'asdf-bogus' } + let(:res) { CircleCi::Project.envvar 'mtchavez', 'asdf-bogus' } let(:message) { 'Project not found' } it 'returns a response object' do @@ -433,6 +433,10 @@ res.body['message'].should eql message end end + + context 'envvars deprecation' do + # TODO: Fill this in + end end describe 'set_envvar' do