Skip to content

Michael Dowling mtdowling

Organizations

Amazon Web Services Guzzle - PHP HTTP client and webservice framework Amazon Web Services
April 19, 2014
mtdowling commented on pull request aws/aws-sdk-php-laravel#28
Michael Dowling

I'd be -1 on this because it could potentially cause issues due to moving the files around. Maybe this should only happen in the next major version.

April 19, 2014
mtdowling commented on issue guzzle/guzzle#644
Michael Dowling

Well, I'm 100% sure functions.php works when using PHP 5.4 or greater. I'm not sure why this would fail on Travis, but I don't think this is anythi…

April 19, 2014
mtdowling commented on issue guzzle/guzzle#644
Michael Dowling

Are you running PHP 5.4 or greater? On Apr 18, 2014, at 7:02 PM, Luis Cordova notifications@github.com wrote: I am running a project with guzzle a…

April 19, 2014
mtdowling commented on issue guzzle/guzzle3#24
Michael Dowling

Does this only happen on Travis? On Apr 18, 2014, at 5:38 PM, Luis Cordova notifications@github.com wrote: i am having some problems with the Reso…

April 18, 2014
mtdowling commented on pull request guzzle/guzzle#643
Michael Dowling

Is all this necessary? I only want to support testing through the CLI.

April 18, 2014
mtdowling commented on pull request guzzle/guzzle#643
Michael Dowling

Can you remove this extra line?

April 18, 2014
mtdowling commented on pull request guzzle/guzzle#643
Michael Dowling

Can you make this public and change the name to save() like the FileCookieJar? It might be useful to persist the session data before destructing th…

April 18, 2014
mtdowling commented on pull request guzzle/guzzle#643
Michael Dowling

Can you make this private please?

April 18, 2014
mtdowling commented on pull request guzzle/guzzle#643
Michael Dowling

Sounds like a good idea. Thanks for the PR. I'll add some feedback inline.

April 18, 2014
Michael Dowling

I wonder how this would have worked before. PHP converts numeric strings into integers when indexing arrays. foo.*.bar requires that the result of …

April 18, 2014
Michael Dowling
Ordered map decoding of objects?
April 18, 2014
Michael Dowling

As the docs say, it's not done yet. This repo is a WIP.

April 18, 2014
Michael Dowling
  • Michael Dowling 5cea034
    Adding more of the functions JEP. Still need to properly implement so…
April 17, 2014
April 17, 2014
mtdowling commented on pull request guzzle/guzzle#641
Michael Dowling

No problem, and I'm glad you like the changes :)

April 17, 2014
mtdowling commented on issue guzzle/guzzle#639
Michael Dowling

@damiankloip I took a look at the Drupal subclass, and I have some feedback. public function __construct(array $config = []) { $default_config = a…

April 17, 2014
mtdowling commented on pull request guzzle/guzzle#642
Michael Dowling

I don't think so. I prefer constructor injection over setter injection. Also, keep in mind that adding a new method to the ClientInterface would be…

April 17, 2014
Michael Dowling
April 17, 2014
mtdowling merged pull request guzzle/guzzle#642
Michael Dowling
Added an emitter option to the Client
1 commit with 22 additions and 0 deletions
April 17, 2014
mtdowling commented on pull request guzzle/guzzle#642
Michael Dowling

Awesome. Thanks.

April 17, 2014
mtdowling closed pull request guzzle/guzzle#641
Michael Dowling
Updated docs for query string parameters
April 17, 2014
mtdowling commented on pull request guzzle/guzzle#641
Michael Dowling

That is incorrect: https://github.com/guzzle/guzzle/blob/master/src/ClientInterface.php#L43. Guzzle 4 has various interface changes from Guzzle 3. …

April 17, 2014
Michael Dowling
April 17, 2014
Michael Dowling
April 17, 2014
Michael Dowling
  • Michael Dowling 91ec441
    Making non-API methods of interpreter local
April 17, 2014
Michael Dowling
April 17, 2014
Michael Dowling
  • Michael Dowling 30eaf06
    Making non-API parsing functions locally scoped
April 17, 2014
Michael Dowling
  • Michael Dowling 3fe6cef
    Cleaning up and using peek instead of backtracking
April 17, 2014
Michael Dowling
  • Michael Dowling 27c06e4
    Making lexer methods local that are not part of the API
April 17, 2014
Michael Dowling
Something went wrong with that request. Please try again.