New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods starting with "set" and having non single parameter will prevent POJO construction #73

Merged
merged 2 commits into from Feb 1, 2015

Conversation

Projects
None yet
2 participants
@daivanov
Collaborator

daivanov commented Feb 1, 2015

For example, java.util.Observable cannot be constructed because of setChanged() method. Proposed solution is to skip such methods instead of throwing exception.

@daivanov daivanov changed the title from Methods starting with "set" and non single parameter will prevent POJO construction to Methods starting with "set" and having non single parameter will prevent POJO construction Feb 1, 2015

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 1, 2015

Agreed. Such methods don't one JavaBean rules therefore Podam should ignore them.

mtedone added a commit that referenced this pull request Feb 1, 2015

Merge pull request #73 from daivanov/master
Methods starting with "set" and having non single parameter will prevent POJO construction

@mtedone mtedone merged commit 4c5603d into mtedone:master Feb 1, 2015

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 1, 2015

Could you release 4.7.2.RELEASE please?

@daivanov

This comment has been minimized.

Collaborator

daivanov commented Feb 1, 2015

I have another fix can it go to the same release?

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 1, 2015

Go for it. Going forward it would be nice to write also release notes and publish them on the internal website

Users should know what each release fixed. What do you think?

On 1 Feb 2015, at 19:48, Daniil Ivanov notifications@github.com wrote:

I have another fix can it go to the same release?


Reply to this email directly or view it on GitHub #73 (comment).

@daivanov

This comment has been minimized.

Collaborator

daivanov commented Feb 1, 2015

Good idea, I missed that section. Does website get updated together with release to Maven Central?

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 1, 2015

If you check in the code in src/site, I’ll have to manually build the website and deploy it

On 1 Feb 2015, at 20:01, Daniil Ivanov notifications@github.com wrote:

Good idea, I missed that section. Does website get updated together with release to Maven Central?


Reply to this email directly or view it on GitHub #73 (comment).

@daivanov

This comment has been minimized.

Collaborator

daivanov commented Feb 2, 2015

I've updated release notes and produced 4.7.2.RELEASE.

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 2, 2015

Daniil I was thinking that it would be a good idea to put the release notes
on the README file so that users can see them on GitHub

On Monday, February 2, 2015, Daniil Ivanov notifications@github.com wrote:

I've updated release notes and produced 4.7.2.RELEASE.


Reply to this email directly or view it on GitHub
#73 (comment).

@daivanov

This comment has been minimized.

Collaborator

daivanov commented Feb 2, 2015

Oh, sorry I misunderstood you. GitHub has a feature to add release notes to tags:
https://github.com/mtedone/podam/releases/new?tag=4.7.2.RELEASE

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 2, 2015

No you didn't misunderstood me, I've changed my mind and think it'd be more
effective to store the release notes on GitHub rather than on the public
website.

On Monday, February 2, 2015, Daniil Ivanov notifications@github.com wrote:

Oh, sorry I misunderstood you. GitHub has a feature to add release notes
to tags:
https://github.com/mtedone/podam/releases/new?tag=4.7.2.RELEASE


Reply to this email directly or view it on GitHub
#73 (comment).

@daivanov

This comment has been minimized.

Collaborator

daivanov commented Feb 2, 2015

I added release notes for two last releases for now:
https://github.com/mtedone/podam/releases

@mtedone

This comment has been minimized.

Owner

mtedone commented Feb 2, 2015

Great stuff!

On 2 Feb 2015, at 20:04, Daniil Ivanov notifications@github.com wrote:

I added release notes for two last releases for now:
https://github.com/mtedone/podam/releases https://github.com/mtedone/podam/releases

Reply to this email directly or view it on GitHub #73 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment