New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creatures have type "Summon" in some sets #35

Closed
zephyrfalcon opened this Issue Jun 11, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@zephyrfalcon

zephyrfalcon commented Jun 11, 2015

This isn't so important, but... a few cards in pCEL have 'types': ["Summon"]... shouldn't this be ["Creature"]? By the way, the same is true for creatures in Unglued (and one in Unhinged, "Old Fogey" :-). The 'type' attribute has the same issue.

I realize these are special sets, so maybe the usual "normalization" doesn't apply here?

@Sembiance

This comment has been minimized.

Show comment
Hide comment
@Sembiance

Sembiance Jun 12, 2015

Collaborator

I was aware of the Unglued and Unhinged cards, but I decided to keep them that way since that is the way they are on Gatherer and these are 'funky' sets.

The pCEL cards come from magiccards.info here: http://magiccards.info/uqc/en.html

These cards are not on Gatherer unfortunately, so it is not known whether or not they should be updated with the latest 'oracle' types or not. Due to these being special cards I'm hesitant to change these either, since the Unglued and Unhinged cards which are on gatherer have specifically remained the old original types which seems like a deliberate act by Wizards.

Collaborator

Sembiance commented Jun 12, 2015

I was aware of the Unglued and Unhinged cards, but I decided to keep them that way since that is the way they are on Gatherer and these are 'funky' sets.

The pCEL cards come from magiccards.info here: http://magiccards.info/uqc/en.html

These cards are not on Gatherer unfortunately, so it is not known whether or not they should be updated with the latest 'oracle' types or not. Due to these being special cards I'm hesitant to change these either, since the Unglued and Unhinged cards which are on gatherer have specifically remained the old original types which seems like a deliberate act by Wizards.

@zephyrfalcon

This comment has been minimized.

Show comment
Hide comment
@zephyrfalcon

zephyrfalcon Jun 12, 2015

I assume they won't bother to apply oracle rulings to cards that aren't legal in any format anyway...

Still, for consistency's sake, I personally would change the 'type' and 'types' attributes (there's still the 'originalType' attribute to hold the original values). But it's your project, and your call. :) I can work around it if necessary in my project.

zephyrfalcon commented Jun 12, 2015

I assume they won't bother to apply oracle rulings to cards that aren't legal in any format anyway...

Still, for consistency's sake, I personally would change the 'type' and 'types' attributes (there's still the 'originalType' attribute to hold the original values). But it's your project, and your call. :) I can work around it if necessary in my project.

@Sembiance Sembiance added the discuss label Aug 2, 2015

@Sembiance Sembiance closed this in 420052e Aug 18, 2015

@Sembiance

This comment has been minimized.

Show comment
Hide comment
@Sembiance

Sembiance Aug 18, 2015

Collaborator

I've decided to make the change from Summon to Creature for the remaining cards that used Summon.

Collaborator

Sembiance commented Aug 18, 2015

I've decided to make the change from Summon to Creature for the remaining cards that used Summon.

@SadisticMystic

This comment has been minimized.

Show comment
Hide comment
@SadisticMystic

SadisticMystic Sep 18, 2015

This should probably also apply to Denied!, which is the one Unglued card to use Interrupt as a type.

SadisticMystic commented Sep 18, 2015

This should probably also apply to Denied!, which is the one Unglued card to use Interrupt as a type.

@Sembiance

This comment has been minimized.

Show comment
Hide comment
@Sembiance

Sembiance Sep 21, 2015

Collaborator

@SadisticMystic I agree. It'll get changed in the next update.

Collaborator

Sembiance commented Sep 21, 2015

@SadisticMystic I agree. It'll get changed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment