Skip to content

Commit

Permalink
Merge branch 'perfcounters-fixes-for-linus-2' of git://git.kernel.org…
Browse files Browse the repository at this point in the history
…/pub/scm/linux/kernel/git/tip/linux-2.6-tip

* 'perfcounters-fixes-for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  perf tools: Make 'make html' work
  perf annotate: Fix segmentation fault
  perf_counter: Fix the PARISC build
  perf_counter: Check task on counter read IPI
  perf: Rename perf-examples.txt to examples.txt
  perf record: Fix typo in pid_synthesize_comm_event
  • Loading branch information
torvalds committed Aug 19, 2009
2 parents c124891 + b395cd8 commit d46c7d9
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 2 deletions.
15 changes: 15 additions & 0 deletions kernel/perf_counter.c
Expand Up @@ -1503,10 +1503,21 @@ static void perf_counter_enable_on_exec(struct task_struct *task)
*/
static void __perf_counter_read(void *info)
{
struct perf_cpu_context *cpuctx = &__get_cpu_var(perf_cpu_context);
struct perf_counter *counter = info;
struct perf_counter_context *ctx = counter->ctx;
unsigned long flags;

/*
* If this is a task context, we need to check whether it is
* the current task context of this cpu. If not it has been
* scheduled out before the smp call arrived. In that case
* counter->count would have been updated to a recent sample
* when the counter was scheduled out.
*/
if (ctx->task && cpuctx->task_ctx != ctx)
return;

local_irq_save(flags);
if (ctx->is_active)
update_context_time(ctx);
Expand Down Expand Up @@ -2008,6 +2019,10 @@ int perf_counter_task_disable(void)
return 0;
}

#ifndef PERF_COUNTER_INDEX_OFFSET
# define PERF_COUNTER_INDEX_OFFSET 0
#endif

static int perf_counter_index(struct perf_counter *counter)
{
if (counter->state != PERF_COUNTER_STATE_ACTIVE)
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/Documentation/Makefile
Expand Up @@ -35,7 +35,7 @@ man7dir=$(mandir)/man7
# DESTDIR=

ASCIIDOC=asciidoc
ASCIIDOC_EXTRA =
ASCIIDOC_EXTRA = --unsafe
MANPAGE_XSL = manpage-normal.xsl
XMLTO_EXTRA =
INSTALL?=install
Expand Down
File renamed without changes.
7 changes: 7 additions & 0 deletions tools/perf/builtin-annotate.c
Expand Up @@ -980,6 +980,13 @@ process_fork_event(event_t *event, unsigned long offset, unsigned long head)
(void *)(long)(event->header.size),
event->fork.pid, event->fork.ppid);

/*
* A thread clone will have the same PID for both
* parent and child.
*/
if (thread == parent)
return 0;

if (!thread || !parent || thread__fork(thread, parent)) {
dprintf("problem processing PERF_EVENT_FORK, skipping event.\n");
return -1;
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/builtin-record.c
Expand Up @@ -219,7 +219,7 @@ static pid_t pid_synthesize_comm_event(pid_t pid, int full)
snprintf(filename, sizeof(filename), "/proc/%d/status", pid);

fp = fopen(filename, "r");
if (fd == NULL) {
if (fp == NULL) {
/*
* We raced with a task exiting - just return:
*/
Expand Down

0 comments on commit d46c7d9

Please sign in to comment.