Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Mar 27, 2010
  1. @aurel32

    error: Move qerror_report() from qemu-error.[ch] to qerror.[ch]

    Markus Armbruster authored aurel32 committed
    Signed-off-by: Markus Armbruster <>
    Signed-off-by: Aurelien Jarno <>
  2. @aurel32

    error: Make use of error_set_progname() optional

    Markus Armbruster authored aurel32 committed
    Signed-off-by: Markus Armbruster <>
    Signed-off-by: Aurelien Jarno <>
Commits on Mar 23, 2010
  1. @edgarigl

    qemu-error: Avoid build warning.

    edgarigl authored
      CC    qemu-error.o
    cc1: warnings being treated as errors
    /home/edgar/src/c/qemu/git/qemu/qemu-error.c: In function 'error_print_loc':
    /home/edgar/src/c/qemu/git/qemu/qemu-error.c:191: error: format not a string literal and no format arguments
    make: *** [qemu-error.o] Error 1
    Signed-off-by: Edgar E. Iglesias <>
Commits on Mar 16, 2010
  1. error: New error_printf_unless_qmp()

    Markus Armbruster authored
  2. error: Let converted handlers print in human monitor

    Markus Armbruster authored
    While fully converted handlers are not supposed to print anything when
    running in a QMP monitor, they are free to print in a human monitor.
    For instance, device_add (not yet converted) prints help, and will
    continue to do so after conversion.
    Moreover, utility functions converted to QError should remain usable
    from unconverted handlers.
    Two problems:
    * handler_audit() complains when a converted handler prints.  Limit
      that to QMP monitors.
    * With QMP, handlers need to pass the error object by way of
      monitor_set_error().  However, we do that both for QMP and for the
      human monitor.  The human monitor prints the error object after the
      handler returns.  If the handler prints anything else, that output
      "overtakes" the error message.
      Limit use of monitor_set_error() to QMP monitors.  Update
      handler_audit() accordingly.
  3. error: Track locations on command line

    Markus Armbruster authored
    New LOC_CMDLINE.  Use it for tracking option with argument in
    lookup_opt().  We now report errors like this
        qemu: -device smbus-eeprom: Did not find I2C bus for smbus-eeprom
  4. error: Track locations in configuration files

    Markus Armbruster authored
    New LOC_FILE.  Use it for tracking file name and line number in
    qemu_config_parse().  We now report errors like
        qemu:foo.conf:42: Did not find I2C bus for smbus-eeprom
    In particular, gems like this message:
        -device: no driver specified
    become almost nice now:
        qemu:foo.conf:44: -device: no driver specified
    (A later commit will get rid of the bogus -device:)
  5. error: Include the program name in error messages to stderr

    Markus Armbruster authored
  6. error: Infrastructure to track locations for error reporting

    Markus Armbruster authored
    New struct Location holds a location.  So far, the only location is
    LOC_NONE, so this doesn't do anything useful yet.
    Passing the current location all over the place would be too
    cumbersome.  Hide it away in static cur_loc instead, and provide
    accessors.  Print it in error_report().
    Store it in QError, and print it in qerror_print().
    Store it in QemuOpt, for use by qemu_opts_foreach().  This makes
    error_report() do the right thing when it runs within
    We may still have to store it in other data structures holding user
    input for better error messages.  Left for another day.
  7. error: Rename qemu_error_new() to qerror_report()

    Markus Armbruster authored
  8. error: Replace qemu_error() by error_report()

    Markus Armbruster authored
    error_report() terminates the message with a newline.  Strip it it
    from its arguments.
    This fixes a few error messages lacking a newline:
    net_handle_fd_param()'s "No file descriptor named %s found", and
    tap_open()'s "vnet_hdr=1 requested, but no kernel support for
    IFF_VNET_HDR available" (all three versions).
    There's one place that passes arguments without newlines
    intentionally: load_vmstate().  Fix it up.
  9. error: New error_printf() and error_vprintf()

    Markus Armbruster authored
  10. error: Simplify error sink setup

    Markus Armbruster authored
    qemu_error_sink can either point to a monitor or a file.  In practice,
    it always points to the current monitor if we have one, else to
    stderr.  Simply route errors to the current monitor or else to stderr,
    and remove qemu_error_sink along with the functions to control it.
    Actually, the old code switches the sink slightly later, in
    handle_user_command() and handle_qmp_command(), than it gets switched
    now, implicitly, by setting the current monitor in monitor_read() and
    monitor_control_read().  Likewise, it switches back slightly earlier
    (same places).  Doesn't make a difference, because there are no calls
    of qemu_error() in between.
  11. error: Move qemu_error() & friends from monitor.c to own file

    Markus Armbruster authored
    They're about reporting errors, not about the monitor.
Something went wrong with that request. Please try again.