Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRecent update ordering: Current week always before previous week #287
Comments
This comment has been minimized.
This comment has been minimized.
|
I've added a unit test that demonstrates correct functionality: https://github.com/mtlynch/whatgotdone/compare/recent-order?expand=1 This unit test currently fails. Anyone interested in contributing to What Got Done can fix this issue by making the unit test pass (you don't have to register an account anywhere or set up databases): To fix this bug:
git remote add mtlynch https://github.com/mtlynch/whatgotdone.git
git checkout -b recent-order
git pull mtlynch recent-order
go test ./...The test will fail because of the bug. Make necessary changes to Push to your fork and make a pull request when the unit test passes. |
enc
pushed a commit
to enc/whatgotdone
that referenced
this issue
Sep 26, 2019
fixes mtlynch#287 Better order for journal entries in test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a bug in the ordering in the response of
recentEntriesGet(alluded to in dtq's recent update) where you can bump a previous week's update to the front of the recent entries list by making an edit to it.This isn't the ideal behavior.
Desired behavior
Order updates like:
Order first by week of update, then by last modified time (in descending order):
Current behavior
Order exclusively by last modified time (in descending order), which sometimes bumps previous weeks ahead of the current week: