New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Area7 gem structure w mtodd testdbs #14
Open
bbozo
wants to merge
17
commits into
mtodd:master
Choose a base branch
from
bbozo:area7_gem_structure_w_mtodd_testdbs
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lot has been deprecated in Rake so we need to install things like RDoc. Also prepare the ground for usage of rake-compiler.
Move things out of root of the gem to avoid things like: require "extconf" Messing things up Once extension is compiled it will be moved by RubyGems to lib directory, so there is no need to indicate "." be added to the $LOAD_PATH
This resolves the deprecation warning caused by usage of old rake.
Instead of duplicated gemspec to maintain, load the spec from the file.
This solve deprecation warnings and also ensure gems get properly packaged.
This opens the door for cleaner compilation and later add cross compilation support.
Without it, Ruby 1.9.x can't read the test file. Rake::TestTask automatically adds 'lib' directory to $LOAD_PATH.
Clobber the data files from 'data' when requested. Also ignore data directory from Git.
Since test already depends on compile
And rename it to match the module it is testing.
For some country+region combos, region_name might not be found, which results in a NULL string and causes segfault when strlen() is performed on it.
The first failed test is also legit, we need another IP with no region set, this one has a region now. The other failed test isn't even submitted among issues here, actually... there's no issues button here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most failing tests were due to outdated IP resolutions, see https://gist.github.com/bbozo/5523578
Remaining fails are: