Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area7 gem structure w mtodd testdbs #14

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

bbozo
Copy link

@bbozo bbozo commented May 6, 2013

Most failing tests were due to outdated IP resolutions, see https://gist.github.com/bbozo/5523578

Remaining fails are:

  1) Failure:
test_blank_region_skips_region_name_set(GeoIPCityTest) [/home/bbozo/dev/geoip/test/test_geoip.rb:142]:
<nil> expected but was
<"00">.

  2) Failure:
test_character_encoding_converted_to_utf8_first(GeoIPCityTest) [/home/bbozo/dev/geoip/test/test_geoip.rb:136]:
<"São Paulo"> expected but was
<"S\xC3\xA3o Paulo">.

luislavena and others added 17 commits January 16, 2013 16:17
Lot has been deprecated in Rake so we need to install things like
RDoc.

Also prepare the ground for usage of rake-compiler.
Move things out of root of the gem to avoid things like:

  require "extconf"

Messing things up

Once extension is compiled it will be moved by RubyGems to lib
directory, so there is no need to indicate "." be added to the
$LOAD_PATH
This resolves the deprecation warning caused by usage of old rake.
Instead of duplicated gemspec to maintain, load the spec from the
file.
This solve deprecation warnings and also ensure gems get properly
packaged.
This opens the door for cleaner compilation and later add cross
compilation support.
Without it, Ruby 1.9.x can't read the test file.

Rake::TestTask automatically adds 'lib' directory to $LOAD_PATH.
Clobber the data files from 'data' when requested.

Also ignore data directory from Git.
Since test already depends on compile
And rename it to match the module it is testing.
For some country+region combos, region_name might not be found, which
results in a NULL string and causes segfault when strlen() is performed
on it.
@bbozo
Copy link
Author

bbozo commented May 6, 2013

The first failed test is also legit, we need another IP with no region set, this one has a region now. The other failed test isn't even submitted among issues here,

actually... there's no issues button here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants