Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing linux/pci-aspm.h in latest Linux release candidate #19

Open
stuart-little opened this issue Sep 25, 2019 · 0 comments

Comments

@stuart-little
Copy link

commented Sep 25, 2019

r8168_n.c includes linux/pci-aspm.h:

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,26)
#include <linux/pci-aspm.h>                                                                                                                                                                                                                
#endif

The problem: the latest releases of the Linux kernel remove that file from the tree. For instance, there's

commit 20d3618b25c7e83136f6ff123e59c88230f9cb17
Merge: 5f9e832c1370 7ce2e76a0420
Author: Bjorn Helgaas <bhelgaas@google.com>
Date:   Mon Sep 23 16:10:06 2019 -0500

    Merge branch 'pci/aspm'
    
      - Consolidate ASPM interfaces in linux/pci.h (Krzysztof Wilczynski)
    
    * pci/aspm:
      PCI: Move ASPM declarations to linux/pci.h

r8168_n.c already includes linux/pci.h unconditionally, so it should be fine on this front. I do however get a number of warnings when I comment out the #include <linux/pci-aspm.h> in r8168_n.c (different issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.