Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads in F-droid version #403

Closed
Bubu opened this issue Sep 12, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@Bubu
Copy link

commented Sep 12, 2017

Some user reported that they are seeing ads in the newly released version in f-droid. While that in itself is fine (if done with FOSS software) it should be labeled as such in the repository.

I could not reproduce the ads myself, but I also saw this commit (7131497), so now I'm, not sure what's the status of this. Can you clarify?

@mtotschnig

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2017

My Expenses uses https://github.com/pubnative/pubnative-android-sdk (licensed under MIT licence). Ads are only shown five days after installation. Could you tell me how to label? I will then create a pull request with updated metadata for https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/org.totschnig.myexpenses.txt

@Bubu

This comment has been minimized.

Copy link
Author

commented Sep 12, 2017

@mtotschnig Thanks for your response. It's just adding AntiFeatures:Ads at the top of the file.

Here is the documentation on these: https://f-droid.org/docs/Build_Metadata_Reference/#AntiFeatures

It's probably a good idea to explain in the description that purchasing the contrib/extended version disables the ads. (I assume that's the case anyway.)

@mtotschnig

This comment has been minimized.

@Bubu

This comment has been minimized.

Copy link
Author

commented Sep 13, 2017

Thanks, can be closed then.

@Bubu Bubu closed this Sep 13, 2017

@mtotschnig mtotschnig referenced this issue Oct 30, 2017

Closed

Ads??? #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.