Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to mdns_lite 0.8 #3

Merged
merged 12 commits into from Oct 7, 2021
Merged

update to mdns_lite 0.8 #3

merged 12 commits into from Oct 7, 2021

Conversation

petermm
Copy link
Contributor

@petermm petermm commented Sep 23, 2021

updating mdns_lite (mix deps.update) currently fails as 0.8 had a breaking change with *_mdns_services going singular..
https://hexdocs.pm/mdns_lite/MdnsLite.html#add_mdns_service/1

thus fixing this AND locking the mdns_lite dep to the 0.8.x versions for future proofing..

tests not affected.

note: mdns_lite brings in vintage_net since 0.7, thus the extra deps in mix.lock - https://hexdocs.pm/mdns_lite/0.8.1/changelog.html

@mtrudel
Copy link
Owner

mtrudel commented Sep 23, 2021

You're braver than me; mDNS has been the bane of my existence on this project (i've gone through all the libraries and they all come up short in one way or another. DNS is a tricky thing I guess). Once you manage to sort out CI on here I'll pull it down and kick the tires locally.

@mtrudel
Copy link
Owner

mtrudel commented Sep 24, 2021

@petermm just to make sure your hard work gets put to good use, please do ping me if this is ready for review / merge and I'm not being timely. There's a lot of (necessary) noise here and I want to make sure I don't miss anything.

@mtrudel
Copy link
Owner

mtrudel commented Sep 29, 2021

@petermm tests are green - is this ready for review?

@petermm
Copy link
Contributor Author

petermm commented Sep 29, 2021

@mtrudel while CI is green - I've come to realise that mdns_lite 0.8 removes support for named services, and they are now all back to being advertised under the hostname (you added named services in the past nerves-networking/mdns_lite#10)

one can change the hostname to "My lightbulb" or similar - but unsure if one might run multiple HapServer from same device and that is a limit..

So something for you to consider, on how to proceed, potentially named services can be added to mdns_lite again..

It does have it's advantages going to 0.8 (say working out of the box on latest nerves, and things like nerves livebooks etc). - but staying behind might also be good - your decision..

@mtrudel
Copy link
Owner

mtrudel commented Sep 29, 2021

Thanks for the research @petermm - the ability to add named services is a bit of a big deal for HAP (which is why nerves-networking/mdns_lite#10 was submitted in the first place). This puts us in a bit of a hard place here as being able to run on the latest Nerves is also kind of a big deal for HAP. Ultimately this PR (or something very close to it) should land, but I'd like to see what can be done about preserving name-based mDNS as well.

Going through the mdns_lite changelog I don't see anything indicating that the feature's removal was intentional; perhaps this is a regression. I'm booked solid for the next few weeks getting my ElixirConf talk ready, but I'll come back to this and try to get to a resolution once I'm past that. Thanks for your patience.

@mtrudel mtrudel merged commit 9e355a4 into mtrudel:main Oct 7, 2021
@mtrudel
Copy link
Owner

mtrudel commented Oct 7, 2021

Merged! As soon as I get green CI on main I'll cut a new hex release. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants