From 14c00f337cae6931b05348b567efba2fe5a11da1 Mon Sep 17 00:00:00 2001 From: Matheus Teixeira Date: Sat, 28 Sep 2019 00:28:09 -0300 Subject: [PATCH] master: fix SQLite asking for passwords. Closes #396 --- packages/plugins/connection-manager/extension.ts | 4 ++-- packages/ui/screens/Settings/Widget/ConnectionInfo.tsx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/plugins/connection-manager/extension.ts b/packages/plugins/connection-manager/extension.ts index 210f6f22e..a41651e29 100644 --- a/packages/plugins/connection-manager/extension.ts +++ b/packages/plugins/connection-manager/extension.ts @@ -1,7 +1,7 @@ import logger from '@sqltools/core/log/vscode'; import ConfigManager from '@sqltools/core/config-manager'; import { EXT_NAME } from '@sqltools/core/constants'; -import { ConnectionInterface } from '@sqltools/core/interface'; +import { ConnectionInterface, DatabaseDialect } from '@sqltools/core/interface'; import getTableName from '@sqltools/core/utils/query/prefixed-tablenames'; import SQLTools, { RequestHandler } from '@sqltools/core/plugin-api'; import { getConnectionDescription, getConnectionId, isEmpty } from '@sqltools/core/utils'; @@ -41,7 +41,7 @@ export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin private ext_testConnection = async (c: ConnectionInterface) => { let password = null; - if (c.askForPassword) password = await this._askForPassword(c); + if (c.dialect !== DatabaseDialect.SQLite && c.askForPassword) password = await this._askForPassword(c); if (c.askForPassword && password === null) return; return this.client.sendRequest( TestConnectionRequest, diff --git a/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx b/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx index 84a77fd2c..85f5c8d7c 100644 --- a/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx +++ b/packages/ui/screens/Settings/Widget/ConnectionInfo.tsx @@ -50,7 +50,7 @@ const ConnectionInfo = ({ updateSettings, submit, toggleGlobal, testConnection, - {
{JSON.stringify(connectionSettings, null, 2)}
} + {/* {
{JSON.stringify(connectionSettings, null, 2)}
} */} {/* {
{JSON.stringify(errors, null, 2)}
} */} {/* {
{JSON.stringify(state, null, 2)}
} */}