From f1d5056727a03a9b3f888904e7ef03ed092d4b6d Mon Sep 17 00:00:00 2001 From: Matheus Teixeira Date: Thu, 30 May 2019 01:11:37 -0300 Subject: [PATCH] Fixes exporting failing. Closes #257 --- packages/plugins/connection-manager/extension.ts | 1 + .../plugins/connection-manager/screens/provider.ts | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/plugins/connection-manager/extension.ts b/packages/plugins/connection-manager/extension.ts index 76f86d7f4..bd7755489 100644 --- a/packages/plugins/connection-manager/extension.ts +++ b/packages/plugins/connection-manager/extension.ts @@ -175,6 +175,7 @@ export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin private ext_showOutputChannel = () => (console).show(); private ext_saveResults = async (filetype: 'csv' | 'json', connId?: string) => { + connId = typeof connId === 'string' ? connId : undefined; filetype = typeof filetype === 'string' ? filetype : undefined; let mode: any = filetype || ConfigManager.defaultExportType; if (mode === 'prompt') { diff --git a/packages/plugins/connection-manager/screens/provider.ts b/packages/plugins/connection-manager/screens/provider.ts index 8b90d19f5..48ecc7d96 100644 --- a/packages/plugins/connection-manager/screens/provider.ts +++ b/packages/plugins/connection-manager/screens/provider.ts @@ -69,11 +69,11 @@ export default abstract class WebviewProvider implements Disposable this.panel.reveal(this.wereToShow, this.preserveFocus); this.postMessage({ action: 'reset' }); this.setPreviewActiveContext(true); - if (process.env.NODE_ENV === 'development') { - setTimeout(() => { - commands.executeCommand('workbench.action.webview.openDeveloperTools'); - }, 1000); - } + // if (process.env.NODE_ENV === 'development') { + // setTimeout(() => { + // commands.executeCommand('workbench.action.webview.openDeveloperTools'); + // }, 1000); + // } } private onDidReceiveMessage = ({ action, payload, ...rest}) => {