Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code completion is a little too fuzzy #193

Closed
ransagy opened this issue Apr 24, 2019 · 10 comments

Comments

3 participants
@ransagy
Copy link

commented Apr 24, 2019

Describe the bug
When triggering code completion for SQL, The results i get are a little too verbose for what i wrote. For example, Writing SomethingID and triggering completion, I get results that just contain ID or just contain Something, That seems wrong to me in such cases as i explicitly wrote both.

To Reproduce
Steps to reproduce the behavior:

  1. Open a new SQL tab
  2. Connect to a DB
  3. Write a simple select query for any table with a column ending with the word ID.
  4. Trigger code completion. Columns with partial matches appear.

Expected behavior
Only columns that have the full typed word, i.e. SomethingID will be shown.

Desktop (please complete the following information):

  • VS Version: 1.33.1 (user setup)
  • OS: Windows_NT x64 10.0.17763 (Windows 10 Pro)
  • SQLTools Version v0.17.15.

@ransagy ransagy added the bug label Apr 24, 2019

@project-bot project-bot bot added this to To do in Kanban Apr 24, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2019

Hi @ransagy.

Please try to tweak IntelliSense settings a bit, we don't have much power on this fuzzy search since it's provide by VSCode, I just give it a list to be searchable.

Take a look here: https://code.visualstudio.com/docs/editor/intellisense#_settings

I'll close this since there is another on going work on issue #110 that would reduce the number of itens in the completion list, ok?

Let me know if you have succeeded on tweaking.

Thanks!

@mtxr mtxr closed this Apr 24, 2019

Kanban automation moved this from To do to To be released Apr 24, 2019

@ransagy

This comment has been minimized.

Copy link
Author

commented Apr 24, 2019

Any idea if those are changes in newer VSCode version? Anyway, Tweaking any of those doesn't help, It still matches things incredibly fuzzy (almost searching for every letter match or so) making it very hard to find what you're looking for.

Closest issue i found is microsoft/vscode#52789 but toggling that setting, even with a restart to VSCode, doesn't seem to affect it all.

I guess i'll look forward to your other change hoping it reduces the pain from VSCode's change.

EDIT: OK, So this is an open issue in VSCode (microsoft/vscode#64367) that they seem to fighting tooth and nail against the developers/against having the option to disable.

@ransagy

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

@mtxr See the suggestion in the latter vscode issue. Can we do something about it?

@mtxr

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

@ransagy Yeah, I saw the issue you commented on VSCode. I'll take a look and release it today

@mtxr

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

Sorry I tooke longer to reply. Response edits are not notified via email.

@mtxr mtxr reopened this Apr 29, 2019

Kanban automation moved this from To be released to In progress Apr 29, 2019

@project-bot project-bot bot moved this from In progress to To do in Kanban Apr 29, 2019

@mtxr mtxr self-assigned this Apr 29, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban Apr 29, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Apr 29, 2019

Closed in ac9487a

@mtxr mtxr closed this Apr 29, 2019

Kanban automation moved this from In progress to To be released Apr 29, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

@ransagy how is it going with the new version? Fixed?

@benyaminl

This comment has been minimized.

Copy link

commented May 1, 2019

Describe the bug
When triggering code completion for SQL, The results i get are a little too verbose for what i wrote. For example, Writing SomethingID and triggering completion, I get results that just contain ID or just contain Something, That seems wrong to me in such cases as i explicitly wrote both.
To Reproduce
Steps to reproduce the behavior:

Open a new SQL tab
Connect to a DB
Write a simple select query for any table with a column ending with the word ID.
Trigger code completion. Columns with partial matches appear.

Expected behavior
Only columns that have the full typed word, i.e. SomethingID will be shown.
Desktop (please complete the following information):

VS Version: 1.33.1 (user setup)
OS: Windows_NT x64 10.0.17763 (Windows 10 Pro)
SQLTools Version v0.17.15.

If you consider maybe support @mtxr monthly via this link https://www.patreon.com/mteixeira/posts.
5 USD for a cup of coffee a month doesn't hurt but it will help his wife allow him to work more on this tools :)

@ransagy

This comment has been minimized.

Copy link
Author

commented May 1, 2019

@mtxr Indeed, It works much better now, Much appreciated! Now I'll wait for the feature to limit it by table/schema (or at least prioritize it with the scoring/filtering system VSCode has) that you're working on for another issue, But this is at least now in a state that is useful for day to day work.

@benyaminl Despite not the place to have this discussion (on a specific issue), As you can see from the main README section - I already have donated.

@benyaminl

This comment has been minimized.

Copy link

commented May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.