Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken HTML View #200

Closed
benyaminl opened this issue May 1, 2019 · 12 comments

Comments

2 participants
@benyaminl
Copy link

commented May 1, 2019

Describe the bug
The HTML result of query is broken. Maybe VS Code change something. Look at this
image

To Reproduce
Steps to reproduce the behavior:

  1. Do any query and this will happens
  2. See error

Expected behavior
It should be like before, not like this.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • SQLTools Version v0.17.17
  • VSCode Version: 1.33.1 User setup
  • Dialect Used: All
  • OS: Windows 10 1809

@benyaminl benyaminl added the bug label May 1, 2019

@project-bot project-bot bot added this to To do in Kanban May 1, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

Hi @benyaminl,

Can you send me a screenshot of the HTML debug view?

Here is how to do it:
https://imgur.com/a/7k7HGpK

I want to check what is happening with the CSS of the table for you. I saw that bug before, but it was quickly fixed a month ago and should not be happening anymore.

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

That as updated on issue #158 per MS request,

mtxr added a commit that referenced this issue May 1, 2019

@mtxr mtxr self-assigned this May 1, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban May 1, 2019

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Hi @benyaminl,
Can you send me a screenshot of the HTML debug view?
Here is how to do it:
https://imgur.com/a/7k7HGpK
I want to check what is happening with the CSS of the table for you. I saw that bug before, but it was quickly fixed a month ago and should not be happening anymore.

So sad leh, imgur blocked in Indonesia. I've seen it using host file.

So it's here.
image
Or maybe I need to remove and add the extension again?
Thanks.
image

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 1, 2019

Anyway I tried install and reinstall also clean the extension cache no help, still not working anyway. VS Code having a hard time -_-. Or maybe there's a extension that's collided with yours?

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 1, 2019

That as updated on issue #158 per MS request,

It said that ver 1.34, mine is 1.33, is that any possibility that it's not working on 1.33.1 ? I tried to update no new update from VS Code. Also no update from website. Hmm.. Why VS Code always break someone extension.. -_-

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

@benyaminl can you do the screenshots again? I need to see going font-family css prop :D

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

@benyaminl https://transfer.sh/9985o/sqltools-0.17.17.htmlfix.vsix try this VSIX file with the commit 8b5e854

I believe that fixes for you.

Use the command palette, search by VSIX and hit enter, pick the file, install and reload.

Let me know how it goes.

Thanks!

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 1, 2019

Anyway I tried install and reinstall also clean the extension cache no help, still not working anyway. VS Code having a hard time -_-. Or maybe there's a extension that's collided with yours?

Sorry I didn't see this message before. VSCode are struggling a lot to link customization settings with CSS variables on webviews, so it's expected to have some problems with CSS. I'm expecting then to change a bit at least for the next 2 releases. At least those changes are not very complex, so we can quickly fix it, even though I was not expecting that for happening in version 1.34. It's the same I'm using..

@mtxr mtxr moved this from In progress to To be released in Kanban May 1, 2019

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 2, 2019

@benyaminl https://transfer.sh/9985o/sqltools-0.17.17.htmlfix.vsix try this VSIX file with the commit 8b5e854
I believe that fixes for you.
Use the command palette, search by VSIX and hit enter, pick the file, install and reload.
Let me know how it goes.
Thanks!

Transfer.sh also blocked in my country -_-. Ah.

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 2, 2019

@benyaminl can you do the screenshots again? I need to see going font-family css prop :D

image
This one?

@benyaminl

This comment has been minimized.

Copy link
Author

commented May 2, 2019

Anyway I tried install and reinstall also clean the extension cache no help, still not working anyway. VS Code having a hard time -_-. Or maybe there's a extension that's collided with yours?

Sorry I didn't see this message before. VSCode are struggling a lot to link customization settings with CSS variables on webviews, so it's expected to have some problems with CSS. I'm expecting then to change a bit at least for the next 2 releases. At least those changes are not very complex, so we can quickly fix it, even though I was not expecting that for happening in version 1.34. It's the same I'm using..

It's usable for now. Maybe need to wait for 1.34 version rolled out. Thanks Mat 👍
image

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 2, 2019

@benyaminl nice!

I'll release another version in a few hours. While waiting, try to tweak the results CSS using this settings:

"sqltools.results": {
    "customization": {
      "table-cell-padding": "4px 8px"
    }
  },

@mtxr mtxr closed this May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.