Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results window header doesn't stay locked to results #201

Closed
omiba opened this issue May 2, 2019 · 2 comments

Comments

2 participants
@omiba
Copy link

commented May 2, 2019

Describe the bug
After selecting a bunch of data with lots of columns that go beyond the screen, when you initially scroll back and forth it works fine, but after going off the tab and resizing a few of the column widths it loses the lock between the header and the data.

To Reproduce
Steps to reproduce the behavior:

  1. Run a query with enough columns to go past the end of your screen (so it will scroll left and right)
  2. Scroll left and right
  3. Resize one of the columns
  4. Scroll left and right
  5. Navigate to another tab (could be the sql one you executed or another)
  6. Navigate back to the results tab
  7. Scroll left and right
  8. Resize one of the columns
  9. Scroll left and right

This process reproduced the issue for me every time.

Expected behavior
The header row and the data rows should always match the data below the header.

Screenshots
Sorry for having to pixelate, but watch around the pixelation and you can see that the data is moving but the header is not.
https://cl.ly/f490acdc234e

Desktop (please complete the following information):

  • SQLTools Version [v0.17.18]
  • VSCode Version: [1.33.1]
  • Dialect Used: [MSSQL]
  • OS: [Mac]

@omiba omiba added the bug label May 2, 2019

@project-bot project-bot bot added this to To do in Kanban May 2, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 3, 2019

No problem @omiba.

I'll work on that, I got it reproduced here, doesn't seem hard to fix. But I'll have time to fix it only tomorrow, ok?

Also thank you for donating! I you update the docs with your name, let me know if you don't want it or want to put another name.

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 5, 2019

Fixes. To be released.

@mtxr mtxr closed this May 5, 2019

Kanban automation moved this from To do to To be released May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.