Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Procedures and Functions Support #208

Closed
mtxr opened this issue May 5, 2019 · 5 comments

Comments

2 participants
@mtxr
Copy link
Owner

commented May 5, 2019

Describe the solution you'd like
We need to add the same support we already have for stored procedures/functionsin PostgeSQL, MySQL and MSSQL to Oracle.

Additional context
There is a query I've used in this project for Sublime Text, see:
https://github.com/mtxr/SublimeText-SQLTools/blob/ca45799b0b1699280478b464a1bc4a44fe4d5454/SQLTools.sublime-settings#L348

The problem is the currently I can't test too much oracle, I've been far way from it for so long that I prefer to let someone with daily experience to do it.

Here is a commit that adds this feature for MSSQL, we basically need to do the same for Oracle and enhance that query provided above a bit.
Related commit: e2295d8

@mtxr

This comment has been minimized.

Copy link
Owner Author

commented May 5, 2019

@mickeypearce if you have time, please take a look at this, let me know what do you think.

@mickeypearce

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

I will gladly do it. 👍

Just help me understand this functionality. It basically lists signatures of functions/procedures (parameters and return values data types) in explorer view. Standalone func/proc and package func/proc all under same tree node, is that correct?

@mtxr

This comment has been minimized.

Copy link
Owner Author

commented May 6, 2019

Yes! Thanks!

Internal functions should not be listed for now. I plan to list it after completing the intellisense in a separate folder of the tree

@project-bot project-bot bot moved this from To do to In progress in Kanban May 6, 2019

@mickeypearce

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

For Oracle I think it should be better to keep the "original" structure:

  • procedures
    -- proc1()
    -- proc2()
  • functions
    -- func1()
    -- func2()
  • packages
    -- pck_1
    ---- func()
    ---- proc()
    -- pck_2

or not? For example If you have 40-50 user packages with more than 1K proc/func it will get quite messy otherwise.

@mtxr

This comment has been minimized.

Copy link
Owner Author

commented May 6, 2019

That's up to you. It's just a change on the tree and we will achieve this. It does make sense to me. Thanks @mickeypearce

@mtxr mtxr closed this in #217 May 8, 2019

Kanban automation moved this from In progress to To be released May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.