Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating an existing global connection BUG. #224

Closed
shyce opened this issue May 10, 2019 · 1 comment

Comments

2 participants
@shyce
Copy link

commented May 10, 2019

Describe the bug
Editing connections doesn't work right. Defaults are displayed instead of the actual connection properties. After updating a connection, the port resets to default because of the prior issue and the old connection name re-appears.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new connection with a non-standard port under MySQL (global:3307).
  2. Edit the connection and change the name.
  3. The port defaults back to 3306 and the connection doesn't work. A new connection with the old name appears when you double-click the new connection name.
  4. Reboot VSCode and the connection works, but editing the connection shows the wrong port (3306).

Expected behavior
I expected that when I edit the connection, no defaults are used but the actual settings are displayed. When updating the port, the old connection re-appears when trying to reconnect - this is a confusing bug.

Desktop (please complete the following information):

  • SQLTools Version: 0.18.2
  • VSCode Version: 1.33.1
  • Dialect Used: MySQL
  • OS: Linux

@shyce shyce added the bug label May 10, 2019

@project-bot project-bot bot added this to To do in Kanban May 10, 2019

@mtxr mtxr self-assigned this May 22, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban May 22, 2019

@mtxr mtxr closed this in 3af990e May 30, 2019

Kanban automation moved this from In progress to To be released May 30, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

Hi @shyce !

How is it going with the extension? Is it working as expected now? Hope so!

Just came to remember, if you like the project, please consider a donation or reviewing it on VSCode marketplace. That you help it to keep evolving.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.