Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
A complete SQL statement will be truncated at a location that may be a keyword #226
How to make this bug shows up
Desktop (please complete the following information):
The Following advice was suggested by my classmate. Is it easy to realize?
I haven't looked through the codebase, so only @mtxr can say better, but i assume it's a case of just correcting a regex in a similar manner to what your classmate suggested, yeah.
Places that could be relevant after searching the codebase:
https://github.com/mtxr/vscode-sqltools/blob/master/packages/core/dialect/mssql/index.ts#L78 - Seems to be OK if i check the regex on its own - Only detects and replaces
https://github.com/mtxr/vscode-sqltools/blob/master/packages/core/utils/query/parse.ts#L123-L129 - Can't quite follow the algorithm here without delving into the other parser parts yet.
https://github.com/mtxr/vscode-sqltools/blob/master/packages/extension/language/sql.tmLanguage.json#L31 - This defines the keyword list, Maybe VSCode itself is doing something odd with it?
I should really install a VSCode extension dev env at some point just to check these things. If you don't get to this "soon", @mtxr , let me know - I'll try to take a shot at it, Seems like a relatively "simple" bug to start with?
No problem, just please, take a few minutes to review it at https://marketplace.visualstudio.com/items?itemName=mtxr.sqltools
That will help more people find the extension as well. More people using, more feedbacks, more improvements, more donations