Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection indicator/progress #229

Closed
ransagy opened this issue May 14, 2019 · 5 comments

Comments

@ransagy
Copy link

commented May 14, 2019

I think it would be a better and more useful user experience if there was some UI element that shows a connection is in progress.

Right now, After connecting, Seemingly "nothing" happens. If we connected, At some point the connection name in the left bottom status bar would change to the connection name. If it failed, We would get a notification, but either might take quite a few seconds where the user has no idea what's going on.

Perhaps add some indication/text to the status bar, possibly a loading animation of some kind, to let the user know a connection attempt is in progress.

@project-bot project-bot bot added this to To do in Kanban May 14, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

There is a new api for progress exchange between the language server and the UI about to be release by vscode team.

I plan to take a look at this once they release it, ok?

But definitely would be great to have a better indicator for that.

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

It uses the withProgress api defined here: https://code.visualstudio.com/api/references/vscode-api#window

But it's controled by the language-server instead of the window instance

@ransagy

This comment has been minimized.

Copy link
Author

commented May 20, 2019

Yeah, definitely, let's take advantage of prior work done by the VSCode team when it's available.

@mtxr mtxr self-assigned this May 22, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban May 22, 2019

@mtxr mtxr removed their assignment May 22, 2019

@project-bot project-bot bot moved this from In progress to To do in Kanban May 22, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

VSCode's June release will bring this to stable channel!

@ransagy

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Nice! Looking forward to it :]

@mtxr mtxr self-assigned this Aug 11, 2019

@mtxr mtxr closed this in d1f93af Aug 11, 2019

Kanban automation moved this from To do to To be released Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.