Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dialect libs extra options without filtering #235

Closed
mrchypark opened this issue May 20, 2019 · 5 comments

Comments

2 participants
@mrchypark
Copy link

commented May 20, 2019

plz let me know how to set path

Thank you in advance.

@project-bot project-bot bot added this to To do in Kanban May 20, 2019

@triage-new-issues triage-new-issues bot added the triage label May 20, 2019

@mrchypark

This comment has been minimized.

Copy link
Author

commented May 20, 2019

I tried link below Additional security options section.

https://dev.mysql.com/doc/dev/connector-nodejs/8.0/tutorial-Secure_Sessions.html

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 27, 2019

We need to develop this feature.

By the link you sent, I believe you are using xprotocol, right?

@mtxr mtxr changed the title How do I set mysql ssl options using pem file it is ssl-ca? Support dialect libs extra options without filtering May 27, 2019

@mtxr mtxr self-assigned this May 27, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban May 27, 2019

@mtxr mtxr added engineering enhancement and removed triage labels May 27, 2019

@mrchypark

This comment has been minimized.

Copy link
Author

commented May 28, 2019

Oh, I just fallow you guys docs like below.

https://vscode-sqltools.mteixeira.dev/connections/mysql

mtxr added a commit that referenced this issue Jun 1, 2019

mtxr added a commit that referenced this issue Jun 1, 2019

mtxr added a commit that referenced this issue Jun 1, 2019

@mtxr mtxr closed this in #263 Jun 1, 2019

Kanban automation moved this from In progress to To be released Jun 1, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Jun 1, 2019

@mrchypark next release will allow you to set ssl ca.

If you are using MySQL default protocol, just to like this:

{
  "host": "localhost",
  "dialect": "MySQL",
  ...,
  "mysqlOptions": {
    "ssl": true,
    "sslOptions": {
      "ca": "/path/to/ca.pem", // Should be a filename. It will be automatically read and used.
      "crl": "/path/to/crl.pem" // Should be a filename. It will be automatically read and used.
    }
  }
}

If you are using MySQL xprotocol protocol, just to like this:

{
  "host": "localhost",
  "dialect": "MySQL",
  ...,
  "mysqlOptions": {
    "ssl": true,
    "sslOptions": {
      "ca": "/path/to/ca.pem",
      "crl": "/path/to/crl.pem"
    }
  }
}

mtxr added a commit that referenced this issue Jun 1, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Jun 2, 2019

@mrchypark How is it going with the extension? Is it working as expected now? Hope so!

Just came to remember, if you like the project, please consider a donation or reviewing it on VSCode marketplace. That you help it to keep evolving.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.