Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running a selected query changes the keyboard focus to the results panel #254

Closed
ransagy opened this issue May 28, 2019 · 1 comment

Comments

2 participants
@ransagy
Copy link

commented May 28, 2019

Describe the bug
Running a selected query moves the keyboard focus to the results panel from the SQL tab. This worked before as far as i remember and allowed for a more streamlined workflow - For example, I could re-run the query again and again with a keyboard shortcut to see progress.

To Reproduce

  1. Open a new SQL tab and connect to a DB.
  2. Run the query either via keyboard shortcut or the command palette.
  3. Try using said keyboard shortcut or command palette again.
  4. Get error about having no query selected because the focus has moved.

Expected behavior
Keyboard focus should remain on the selected query in the tab while the results panel is opened/updated.

Desktop (please complete the following information):

  • SQLTools v0.19.2
  • VSCode 1.34.0
  • Dialect Used: MSSQL + Azure SQL
  • OS: Windows 10 x64

@ransagy ransagy added the bug label May 28, 2019

@project-bot project-bot bot added this to To do in Kanban May 28, 2019

@mtxr mtxr self-assigned this May 30, 2019

@project-bot project-bot bot moved this from To do to In progress in Kanban May 30, 2019

@mtxr mtxr closed this in fddff69 May 30, 2019

Kanban automation moved this from In progress to To be released May 30, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Thanks @ransagy .

I can't remember why I changed it, but taking focus is very obtrusive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.