Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks getting wrong CodeLens comments #258

Closed
Eggybread610 opened this issue May 29, 2019 · 1 comment

Comments

@Eggybread610
Copy link

commented May 29, 2019

Describe the bug
Nothing severe. If I make a bookmark, give it a name and a group. Then I edit that bookmark, it opens a new page with the query and some codelens comments. However it states the the @group is the query name and the @name is the query group.

To Reproduce
Steps to reproduce the behavior:

  1. Create a bookmark, give it a name and group
  2. Edit the same bookmark (ctrl+shift+p Edit Bookmark)

Expected behavior
@name saying the query name and @group saying the query group

Desktop (please complete the following information):

  • SQLTools Version v0.19.2
  • VSCode Version: v1.33.1
  • Dialect Used: PostgreSQL
  • OS: Windows

@Eggybread610 Eggybread610 added the bug label May 29, 2019

@project-bot project-bot bot added this to To do in Kanban May 29, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Hi @Eggybread610 !

Thanks for reaching us with this issue. This is a good first issue to contribute. Would you like to try to fix it?

@mtxr mtxr closed this in c3832ab Aug 10, 2019

Kanban automation moved this from To do to To be released Aug 10, 2019

@mtxr mtxr self-assigned this Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.