Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to force the path to the Oracle client #281

Closed
bergamin opened this issue Jun 26, 2019 · 2 comments

Comments

@bergamin
Copy link

commented Jun 26, 2019

Is your feature request related to a problem? Please describe.

At work I normally use a 32 bits Oracle (I don't know why. The environment comes ready for every new employee and it targets a shared drive), but SQLTools requires 64 bits, giving me the following error when I try to connect:

image

Describe the solution you'd like

it would be great to have a setting to override the environment variable and set it like this:

"sqltools.oracle_home": "Path I want SQLTools to use instead of the default environment variable"

Describe alternatives you've considered

I have both changed the path and oracle_home variables and the message keeps being shown with the wrong path in it. It is still trying to connect to the old path, so may be a bug as well?

Additional context

EDIT

I found out why it wasn't working. I had two environment variables called Path. My suggestion for overriding though, is still valid.

@mickeypearce mickeypearce self-assigned this Jun 27, 2019

@mickeypearce mickeypearce added the oracle label Jun 27, 2019

@mickeypearce

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Node-oracledb driver used in extension doesn't include pre-built 32-bit binaries at the moment unfortunatelly.

But setting ORACLE_HOME could be done through process.env.ORACLE_HOME from setting as you suggested. (oracle/node-oracledb#185)

@mtxr mtxr closed this in 05b7a8f Aug 11, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2019

Just added a config that allows you to achieve this.

This is the text added to the docs:

If you want to use 32bits drivers or set a different ORACLE_HOME to be used with the node driver, you can achieve this using the sqltools.languageServerEnv.

{
  ...
  "sqltools.languageServerEnv": {
    "ORACLE_HOME": "YOUR PATH HERE"
  },
  ...
}

@mtxr mtxr self-assigned this Aug 11, 2019

@mtxr mtxr added this to To do in Kanban via automation Aug 11, 2019

@mtxr mtxr moved this from To do to To be released in Kanban Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.