Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQL: Display of rowversion columns isn't intuitive #344

Closed
ransagy opened this issue Aug 27, 2019 · 2 comments

Comments

@ransagy
Copy link
Contributor

commented Aug 27, 2019

SQL Server has a column type of rowversion that keeps an automatically incremented number, mostly used to verify when a row was changed.

Right now it's displayed as raw data ({"data":[0,0,0,0,124,213,26,20],"type":"Buffer"}) instead of the actual value (i.e. 0x00000000000007D3).

The way it is displayed in SQL Tools is different to other DB tools I've used in the past and the inconsistency is not very intuitive. It also causes the row heights to be greater since so far for me by default it's value is always "wrapped" around more than a single row's height.

I think it would be useful to parse this column type as intended.

https://docs.microsoft.com/en-us/sql/t-sql/data-types/rowversion-transact-sql?view=sql-server-2017

@ransagy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

On a side note; If you think this is a simple change to do as a first issue, please point me in the general direction of where and i'll look into doing a PR.

@mtxr

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2019

Hi @ransagy . I'm trying to figure out how to convert that buffer to the desired value you provided.

To add the support you want, the better place would be here

const ValueRender = ({ value }) => {

But we need to know how to convert it first

@mtxr mtxr added this to To do in Kanban via automation Sep 2, 2019
@mtxr mtxr self-assigned this Sep 2, 2019
@mtxr mtxr closed this in 9d61fd2 Sep 2, 2019
Kanban automation moved this from To do to To be released Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Kanban
  
To be released
2 participants
You can’t perform that action at this time.