Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORA: Add pool configuration (oracleOptions) #204

Merged
merged 2 commits into from May 3, 2019

Conversation

2 participants
@mickeypearce
Copy link
Collaborator

commented May 3, 2019

from #186

@project-bot project-bot bot added this to In progress in Kanban May 3, 2019

@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #204   +/-   ##
======================================
  Coverage    3.51%   3.51%           
======================================
  Files          82      82           
  Lines        2644    2644           
  Branches      395     395           
======================================
  Hits           93      93           
  Misses       2545    2545           
  Partials        6       6
Impacted Files Coverage Δ
packages/core/dialect/oracle/index.ts 0% <ø> (ø) ⬆️
packages/core/utils/errors.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321eb7c...ff8769b. Read the comment docs.

@mtxr

mtxr approved these changes May 3, 2019

@mtxr mtxr merged commit 0808317 into mtxr:master May 3, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details

Kanban automation moved this from In progress to To be released May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.