Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit connection #209

Merged
merged 9 commits into from May 7, 2019

Conversation

1 participant
@mtxr
Copy link
Owner

commented May 5, 2019

No description provided.

mtxr added some commits May 2, 2019

@mtxr mtxr added the ui/ux label May 5, 2019

@mtxr mtxr self-assigned this May 5, 2019

@mtxr mtxr added this to In progress in Kanban via automation May 5, 2019

@codecov

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #209 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #209      +/-   ##
=========================================
+ Coverage    3.51%   3.58%   +0.07%     
=========================================
  Files          82      83       +1     
  Lines        2647    2816     +169     
  Branches      400     562     +162     
=========================================
+ Hits           93     101       +8     
- Misses       2548    2706     +158     
- Partials        6       9       +3
Impacted Files Coverage Δ
packages/ui/screens/Results/Screen.tsx 0% <0%> (ø) ⬆️
packages/core/utils/get-connection-stuff.ts 0% <0%> (ø)
packages/ui/screens/Settings/Screen.tsx 0% <0%> (ø) ⬆️
packages/ui/lib/utils.ts 0% <0%> (ø) ⬆️
packages/ui/components/Syntax.tsx 0% <0%> (ø) ⬆️
...ges/plugins/connection-manager/screens/provider.ts 0% <0%> (ø) ⬆️
packages/ui/screens/Settings/FileInput.tsx 0% <0%> (ø)
...kages/plugins/connection-manager/explorer/index.ts 0% <0%> (ø) ⬆️
packages/core/utils/index.ts 0% <0%> (ø) ⬆️
...ges/plugins/connection-manager/screens/settings.ts 0% <0%> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2810df...17f08c9. Read the comment docs.

@@ -143,6 +143,22 @@ export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin
return this.settingsWebview.show();
}

private ext_openEditConnectionScreen = async (connIdOrNode?: string | SidebarConnection) => {
let id: string;
if (connIdOrNode) {

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 5, 2019

Identical blocks of code found in 2 locations. Consider refactoring.

default:
break;
}
});
}

private updateConnection = async ({ connInfo, isGlobal, editId }) => {
console.log({ connInfo, isGlobal, editId });
commands.executeCommand(`${EXT_NAME}.updateConnection`, editId, connInfo, isGlobal ? 'Global' : undefined)

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 6, 2019

Similar blocks of code found in 2 locations. Consider refactoring.

newState.fields.port.visible = !this.state.data.useSocket;
newState.fields.socketPath.visible = !!this.state.data.useSocket;
switch (this.state.data.connectionMethod) {
case ConnectionMethod.ConnectionString:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 7, 2019

Similar blocks of code found in 3 locations. Consider refactoring.

newState.fields.socketPath.visible = false;
newState.fields.connectString.visible = true;
break;
case ConnectionMethod.Socket:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 7, 2019

Similar blocks of code found in 3 locations. Consider refactoring.

newState.fields.socketPath.visible = true;
newState.fields.connectString.visible = false;
break;
case ConnectionMethod.ServerAndPort:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 7, 2019

Similar blocks of code found in 3 locations. Consider refactoring.

@codeclimate

This comment has been minimized.

Copy link

commented May 7, 2019

Code Climate has analyzed commit 59dcccc and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 7

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 18.0% (1.1% change).

View more on Code Climate.

@mtxr mtxr merged commit 1cb143d into master May 7, 2019

2 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details
codeclimate Code Climate is analyzing this code.
Details
Gitpod Open a prebuilt online workspace in Gitpod
Details
WIP Ready for review
Details

Kanban automation moved this from In progress to To be released May 7, 2019

@mtxr mtxr deleted the feature/edit-connection branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.