Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
SAP Hana dialect #215
@@ Coverage Diff @@ ## master #215 +/- ## ========================================= - Coverage 4.15% 4.15% -0.01% ========================================= Files 82 83 +1 Lines 2622 2626 +4 Branches 514 515 +1 ========================================= Hits 109 109 - Misses 2504 2508 +4 Partials 9 9
mtxr left a comment
@ariel-bentu awesome! You are doing a great job, thanks!
I just commented some places that we wont need or is just a small change. I'm really excited with you PR.
Just explaining a bit about the deps, you can add
On first usage, user will be requested to install it, that helps on packing because it allows us to pack for multi platforms and let node handle deps.
Once you finish here, let me know so I can merge.
Dont forget to write the docs for connecting.
Again, thank you very much! I'll reach you back as soon as I have updates on licensing.
is there a way to advice the dependency manager that this package is?
In addition, why is it not finding the module, if I previouslly installed it globally (manually ran
No, we don't have it for now. But I'll add in you PR, ok? @ariel-bentu
About the modules, for now it's better to install the module inside of the extension folder because in global install users usually have the latest version, and for the extension we are going to fix it in a tested version.
I'll send a review. It's 2 questions only. See below:
@ariel-bentu https://github.com/ariel-bentu/vscode-sqltools/pull/1/files please see and test it, but I believe after this we can merge it on master
May 11, 2019
Regarding the -g option: using a globally installed package instead of requiring installation:
I found that npm has the command link:
It would be nice to first try to link, and if fails (exit code != 0) fall back to installing it. what do you think?