Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
remove cycles in objects that are moving between server and browser #233
@@ Coverage Diff @@ ## master #233 +/- ## ====================================== Coverage 3.51% 3.51% ====================================== Files 85 85 Lines 2960 2960 Branches 605 606 +1 ====================================== Hits 104 104 Misses 2843 2843 Partials 13 13
My changes do not remove anu functionality, thus I belive are right for vscode as well. Can you point me to the breaking function so I can try to fix? Thanks בתאריך יום ב׳, 20 במאי 2019, 07:09, מאת Matheus Teixeira < email@example.com>:…
Cant accept this 'as-is'. It's breaking on VSCode. Is there a env variable that identifies we are running on Theia? This way we could check to use 'VSCode API' or 'Theia API'. Any ideas or suggestions? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#233?email_source=notifications&email_token=AE3ZMN6KDJCRRO7KYTMIG6DPWIP6DA5CNFSM4HN4U3Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVXUS7Q#issuecomment-493832574>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3ZMN6MKXXN6K7WIT5BMCDPWIP6DANCNFSM4HN4U3ZQ> .
May 23, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.