Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open results screen for each connection #234

Merged
merged 3 commits into from May 20, 2019

Conversation

1 participant
@mtxr
Copy link
Owner

commented May 20, 2019

No description provided.

@mtxr mtxr self-assigned this May 20, 2019

@mtxr mtxr added this to In progress in Kanban via automation May 20, 2019

@mtxr mtxr changed the title Feature/results per connection Allow to open results screen for each connection May 20, 2019

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #234 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #234      +/-   ##
=========================================
- Coverage    4.01%   3.72%   -0.29%     
=========================================
  Files          83      85       +2     
  Lines        2717    2923     +206     
  Branches      548     593      +45     
=========================================
  Hits          109     109              
- Misses       2599    2805     +206     
  Partials        9       9
Impacted Files Coverage Δ
packages/ui/screens/Results/ResultsTable.tsx 0% <ø> (ø) ⬆️
...ages/plugins/connection-manager/screens/results.ts 0% <0%> (ø) ⬆️
packages/plugins/connection-manager/extension.ts 0% <0%> (ø) ⬆️
...ges/plugins/connection-manager/screens/provider.ts 0% <0%> (ø) ⬆️
...ges/plugins/connection-manager/screens/settings.ts 0% <0%> (ø) ⬆️
...ages/plugins/dependency-manager/language-server.ts 0% <0%> (ø)
...ages/plugins/connection-manager/language-server.ts 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002be50...811cbe6. Read the comment docs.

}
const payload = await this._runConnectionCommandWithArgs('showRecords', table, limit);
this.resultsWebview.updateResults(payload);
this.resultsWebview.get(payload[0].connId || this.explorer.getActive().id).updateResults(payload);

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 20, 2019

Identical blocks of code found in 3 locations. Consider refactoring.

@@ -63,7 +61,7 @@ export default class ConnectionManagerPlugin implements SQLTools.ExtensionPlugin
const table = await this._getTableName(node);
this._openResultsWebview();
const payload = await this._runConnectionCommandWithArgs('describeTable', table);
this.resultsWebview.updateResults(payload);
this.resultsWebview.get(payload[0].connId || this.explorer.getActive().id).updateResults(payload);

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 20, 2019

Identical blocks of code found in 3 locations. Consider refactoring.

}
await this._setConnection(conn);
}
await this._connect();
this._openResultsWebview();
const payload = await this._runConnectionCommandWithArgs('query', query);
this.resultsWebview.updateResults(payload);
this.resultsWebview.get(payload[0].connId || this.explorer.getActive().id).updateResults(payload);

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 20, 2019

Identical blocks of code found in 3 locations. Consider refactoring.

private viewsPath: Uri;

constructor(private context: vscode.ExtensionContext, private client: SQLTools.LanguageClientInterface) {
this.iconsPath = Uri.file(path.join(this.context.extensionPath, 'icons')).with({ scheme: 'vscode-resource' });

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 20, 2019

Similar blocks of code found in 2 locations. Consider refactoring.


constructor(private context: vscode.ExtensionContext, private client: SQLTools.LanguageClientInterface) {
this.iconsPath = Uri.file(path.join(this.context.extensionPath, 'icons')).with({ scheme: 'vscode-resource' });
this.viewsPath = Uri.file(path.join(this.context.extensionPath, 'ui')).with({ scheme: 'vscode-resource' });

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot May 20, 2019

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate

This comment has been minimized.

Copy link

commented May 20, 2019

Code Climate has analyzed commit 811cbe6 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 7

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 17.5% (-1.1% change).

View more on Code Climate.

@mtxr mtxr merged commit e93e10c into master May 20, 2019

4 of 7 checks passed

codeclimate 7 issues to fix
Details
codecov/patch 0% of diff hit (target 4.01%)
Details
codecov/project 3.72% (-0.29%) compared to 002be50
Details
Gitpod Open a prebuilt online workspace in Gitpod
Details
Mergeable Mergeable Run has been Completed!
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

Kanban automation moved this from In progress to To be released May 20, 2019

@mtxr mtxr deleted the feature/results-per-connection branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.