Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make database configuration relative to the workspace root #255

Merged
merged 4 commits into from May 30, 2019

Conversation

2 participants
@mitchellsimoens
Copy link
Contributor

commented May 28, 2019

Fixes #241 to make the database connection config relative to the workspace.


Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have wrote a description of what is the purpose of this pull request above
@codecov

This comment has been minimized.

Copy link

commented May 28, 2019

Codecov Report

Merging #255 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #255      +/-   ##
=========================================
- Coverage     3.5%   3.49%   -0.02%     
=========================================
  Files          85      85              
  Lines        2965    2975      +10     
  Branches      610     613       +3     
=========================================
  Hits          104     104              
- Misses       2848    2858      +10     
  Partials       13      13
Impacted Files Coverage Δ
...ges/plugins/connection-manager/screens/settings.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776b42d...986a711. Read the comment docs.

mitchellsimoens and others added some commits May 28, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

Thanks @mitchellsimoens! That's awesome!

I've made just a change to use relative path if it's inside of a workspace.

If the file is somewhere out of a workspace, we use the realpath.

@mtxr mtxr merged commit e393827 into mtxr:master May 30, 2019

3 checks passed

Mergeable Mergeable Run has been Completed!
Details
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details

Kanban automation moved this from In progress to To be released May 30, 2019

@mitchellsimoens mitchellsimoens deleted the mitchellsimoens:workspace-relative-path branch May 30, 2019

@mitchellsimoens

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@mtxr nice final solution! this was my first attempt at vscode extension stuff so thanks for helping me along too! Also, thanks for the work on this extension, I think it's gonna be part of my workflows on current and future projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.