Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORA: Add named parameters in func/proc arguments #260

Merged
merged 4 commits into from May 30, 2019

Conversation

2 participants
@mickeypearce
Copy link
Collaborator

commented May 30, 2019

Closes #222

  • added argument datatypes as suggested in issue (user defined data types and boolean)
  • added argument names

@project-bot project-bot bot added this to In progress in Kanban May 30, 2019

@mickeypearce mickeypearce added the oracle label May 30, 2019

@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #260 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #260   +/-   ##
======================================
  Coverage    3.22%   3.22%           
======================================
  Files          86      86           
  Lines        3223    3223           
  Branches      674     674           
======================================
  Hits          104     104           
  Misses       3106    3106           
  Partials       13      13
Impacted Files Coverage Δ
packages/core/dialect/oracle/queries.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f166d...253eefa. Read the comment docs.

mtxr added some commits May 30, 2019

@mtxr

mtxr approved these changes May 30, 2019

@mtxr mtxr merged commit b5c9e14 into mtxr:master May 30, 2019

2 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Mergeable Mergeable Run has been Completed!
Details
codeclimate All good!
Details

Kanban automation moved this from In progress to To be released May 30, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

@mickeypearce before we release, please give it a smoke test that the changes I've made don't break it for you.

I was wondering that after merging. :(

When you say we are good, I'll release

@mtxr

This comment has been minimized.

Copy link
Owner

commented May 30, 2019

@mickeypearce all said, I'll release after work today. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.