Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-grid: Moving to react-grid instead of react-table #297

Merged
merged 7 commits into from Jul 29, 2019

Conversation

@mtxr
Copy link
Owner

commented Jul 22, 2019


Benchmarks

Select 10000 rows x 28 columns

  • Before
    image

  • After
    image

mtxr added some commits Jul 22, 2019

Repository owner deleted a comment from codeclimate bot Jul 24, 2019

Repository owner deleted a comment from codeclimate bot Jul 24, 2019

Repository owner deleted a comment from codecov bot Jul 24, 2019

Repository owner deleted a comment from codeclimate bot Jul 24, 2019

Repository owner deleted a comment from codeclimate bot Jul 24, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 24, 2019

Codecov Report

Merging #297 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #297      +/-   ##
=========================================
+ Coverage    2.97%   3.01%   +0.03%     
=========================================
  Files          89      89              
  Lines        3529    3486      -43     
  Branches      730     710      -20     
=========================================
  Hits          105     105              
+ Misses       3411    3368      -43     
  Partials       13      13
Impacted Files Coverage Δ
...ges/plugins/connection-manager/screens/provider.ts 0% <ø> (ø) ⬆️
packages/ui/lib/utils.ts 0% <0%> (ø) ⬆️
packages/ui/components/Syntax.tsx 0% <0%> (ø) ⬆️
packages/ui/screens/Results/ResultsTable.tsx 0% <0%> (ø) ⬆️
packages/ui/screens/Results/QueryResult.tsx 0% <0%> (ø) ⬆️
...ages/plugins/connection-manager/screens/results.ts 0% <0%> (ø) ⬆️
packages/ui/screens/Results/Screen.tsx 0% <0%> (ø) ⬆️
packages/plugins/connection-manager/extension.ts 0% <0%> (ø) ⬆️
packages/ui/screens/Results/lib/filterPredicate.ts 0% <0%> (ø)
packages/ui/components/Menu.tsx 0% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e717...7acf3cd. Read the comment docs.

);
}
value = String(value);
return <span>{value}</span>;

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Jul 24, 2019

Avoid too many return statements within this function.

@@ -308,7 +178,7 @@ export default class ResultsTable extends React.PureComponent<ResultsTableProps,
}
});
break;
case SaveCSVOption:
case MenuActions.SaveCSVOption:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Jul 24, 2019

Similar blocks of code found in 2 locations. Consider refactoring.

@@ -317,7 +187,7 @@ export default class ResultsTable extends React.PureComponent<ResultsTableProps,
}
});
break;
case SaveJSONOption:
case MenuActions.SaveJSONOption:

This comment has been minimized.

Copy link
@codeclimate

codeclimate bot Jul 24, 2019

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate

This comment has been minimized.

Copy link

commented Jul 24, 2019

Code Climate has analyzed commit b73d4c0 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 2

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 15.2% (0.2% change).

View more on Code Climate.

mtxr added some commits Jul 29, 2019

@mtxr mtxr merged commit 0485dd9 into master Jul 29, 2019

1 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Mergeable Mergeable run returned Status ***FAIL***
Details
codeclimate Code Climate is analyzing this code.
Details
Travis CI - Branch Build Passed
Details

@mtxr mtxr changed the title WIP: react-grid: Moving to react-grid instead of react-table react-grid: Moving to react-grid instead of react-table Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.