Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OrableDB driver to v4 #310

Merged
merged 6 commits into from Aug 25, 2019

Conversation

@greenkeeper
Copy link
Contributor

commented Aug 5, 2019

The devDependency @types/oracledb was updated from 3.1.3 to 4.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: types
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper greenkeeper bot added the greenkeeper label Aug 5, 2019

@codeclimate

This comment has been minimized.

Copy link

commented Aug 5, 2019

Code Climate has analyzed commit 622fc9c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 14.1% (0.2% change).

View more on Code Climate.

@codecov

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@ac95d31). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #310   +/-   ##
========================================
  Coverage          ?   3.03%           
========================================
  Files             ?      88           
  Lines             ?    3423           
  Branches          ?     702           
========================================
  Hits              ?     104           
  Misses            ?    3306           
  Partials          ?      13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac95d31...d6b90dc. Read the comment docs.

@mtxr mtxr requested a review from mickeypearce Aug 10, 2019

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 10, 2019

@mickeypearce how are you?

Hey, this auto-opened PR lead me to this https://github.com/oracle/node-oracledb/blob/master/CHANGELOG.md#node-oracledb-v400-25-jul-2019

Do you think we can update both the library and the types?

I've reviewed the @types files changes, LGTM, but again, can't test.

If you can take a look I'll be glad. If it works fine for you, just push the new versions and accept this PR.

Thanks again, mate!

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 10, 2019

@mickeypearce

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

Hey @mtxr !
I am fine, thanks for asking.

I got an error first: "Error: Request DependencyInstaller/install failed unexpectedly without providing any details." after I upgraded to 4.0.0.

The reason is this:

oracledb ERR! NJS-069: node-oracledb 4.0.0 requires Node.js 10.16 or later
oracledb ERR! An older node-oracledb version may work with Node.js v10.15.1

which I got after I ran "npm install oracledb@4.0.0" separately. Maybe we should return the npm install error message to dependency manager dialog for user to see, because:

(Node-oracledb 4 requires Node.js 8.16 or Node.js 10.16, or higher. Node.js 8.16, 10.16, 11.12 and 12 contain an important N-API performance fix)

After I upgraded the node, 4.0.0 seems to work.

greenkeeper bot added a commit that referenced this pull request Aug 16, 2019
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Update to this version instead 🚀

greenkeeper bot added a commit that referenced this pull request Aug 19, 2019
@greenkeeper

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Update to this version instead 🚀

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 25, 2019

Hey @mtxr !
I am fine, thanks for asking.

I got an error first: "Error: Request DependencyInstaller/install failed unexpectedly without providing any details." after I upgraded to 4.0.0.

The reason is this:

oracledb ERR! NJS-069: node-oracledb 4.0.0 requires Node.js 10.16 or later
oracledb ERR! An older node-oracledb version may work with Node.js v10.15.1

which I got after I ran "npm install oracledb@4.0.0" separately. Maybe we should return the npm install error message to dependency manager dialog for user to see, because:

(Node-oracledb 4 requires Node.js 8.16 or Node.js 10.16, or higher. Node.js 8.16, 10.16, 11.12 and 12 contain an important N-API performance fix)

After I upgraded the node, 4.0.0 seems to work.

Awesome! Very precise explanation! Merging

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 25, 2019

I'll change the code to return the npm message. We've been receiving a lot of issues because of our message. Showing the real message seems fair and more helpful to me too ;)

@mtxr mtxr merged commit 78a122d into master Aug 25, 2019

0 of 4 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
Mergeable Mergeable run returned Status ***FAIL***
Details
codeclimate Code Climate is analyzing this code.
Details

@mtxr mtxr deleted the greenkeeper/default/@types/oracledb-4.0.0 branch Aug 25, 2019

@mtxr mtxr changed the title Update @types/oracledb in group default to the latest version 🚀 Update OrableDB driver to v4 Aug 25, 2019

@mtxr mtxr added this to In progress in Kanban via automation Aug 25, 2019

@mtxr mtxr moved this from In progress to To be released in Kanban Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.