Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support views of HANA #347

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@ariel-bentu
Copy link
Contributor

commented Aug 28, 2019

With this PR, the SAP HANA dialect also shows views (not only tables) in a given connection

Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have wrote a description of what is the purpose of this pull request above
Ariel Bentolila
@ariel-bentu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@mtxr seems that a test fails, locally passes and no info on what test - can you help? tnx

@mtxr

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2019

@mtxr
mtxr approved these changes Aug 30, 2019

@mtxr mtxr merged commit 06b5637 into mtxr:master Aug 30, 2019

0 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Mergeable Mergeable run returned Status ***FAIL***
Details
codeclimate Code Climate is analyzing this code.
Details

@mtxr mtxr added this to In progress in Kanban via automation Aug 30, 2019

@mtxr mtxr moved this from In progress to To be released in Kanban Aug 30, 2019

@offer8

This comment has been minimized.

Copy link

commented Aug 31, 2019

Thanks for the fix! in which version of vscode-sqltools this will be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.