Issue212 selection highlights #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code used Scintilla's built-in findFirst method which changes the active selection as it goes. The attempt to replace the original selection was causing issues when selecting backwards with the keyboard. While it would probably be possible to get the right logic in place by getting the right combination of Scintilla's anchor and caret position, I've simply bypassed the problem by using Python's regex .finditer function to identify matching spans and converting those to Scintilla ranges.
…tor to the right of a selection. Also rework some of the existing highlighter tests to exercise the editor functionality directly, relying less on our underlying implementation
…ccurs which clears the selection)
…plementation does; we can revisit the spec later and decide whether we want this functionality or not. (It doesn't make a ton of sense since, while it's selected, the highlight is hidden by the selected; and once it's unselected, the highlight will be cleared).
|
Build still failing due to PEP8. :-( |
|
Hmmm. I ran all the make checks over it. Ok; I'll have a look.
|
|
Perhaps I'm misunderstanding the output: it looks to me as though the overall merge is passing, but that individual commits are failing -- which they will, since they precede other commits which are exactly fixing up PEP8 errors. Should I have rebased before pushing the PR? |
|
Apologies... looks like it was Travis that had the collywobbles. I hit it with the proverbial spanner and it's gone green. ;-) |
|
Looking at coverage, there's a couple of branches in the code that are not exercised. I'll add/massage the tests to get us back to 100%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the issues discussed in #212 but it builds on the (currently unmerged) work in #209