Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue212 selection highlights #218
Conversation
tjguk
added some commits
Dec 20, 2016
This comment has been minimized.
This comment has been minimized.
|
Build still failing due to PEP8. :-( |
This comment has been minimized.
This comment has been minimized.
|
Hmmm. I ran all the make checks over it. Ok; I'll have a look.
|
This comment has been minimized.
This comment has been minimized.
|
Perhaps I'm misunderstanding the output: it looks to me as though the overall merge is passing, but that individual commits are failing -- which they will, since they precede other commits which are exactly fixing up PEP8 errors. Should I have rebased before pushing the PR? |
This comment has been minimized.
This comment has been minimized.
|
Apologies... looks like it was Travis that had the collywobbles. I hit it with the proverbial spanner and it's gone green. ;-) |
This comment has been minimized.
This comment has been minimized.
|
Looking at coverage, there's a couple of branches in the code that are not exercised. I'll add/massage the tests to get us back to 100%. |
ntoll
merged commit 30240fa
into
mu-editor:master
Dec 22, 2016
ntoll
referenced this pull request
Dec 22, 2016
Closed
Problems selecting text with [shift]+[left arrow] #209
tjguk
deleted the
tjguk:issue212-selection-highlights
branch
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tjguk commentedDec 22, 2016
This PR is for the issues discussed in #212 but it builds on the (currently unmerged) work in #209