Address issues raised with appstreamcli validation #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating the appdata with appstreamcli version 0.12.2 results in the following output:
$ appstreamcli validate conf/mu.appdata.xml
W - mu.appdata.xml:mu.codewith.editor.desktop:29
Found invalid tag: '_developer_name'. Non-standard tags must be prefixed with
"x-".
I - mu.appdata.xml:mu.codewith.editor.desktop:7
The component summary should not end with a "." [A simple Python editor for
beginner programmers.]
E - mu.appdata.xml:mu.codewith.editor.desktop:20
The description contains an URL. This is not allowed, please use the <url/> tag
to share links.
Validation failed: errors: 1, warnings: 1, infos: 1
This update corrects these issues
ZanderBrown
reviewed
Aug 25, 2018
conf/mu.appdata.xml
Outdated
| </description> | ||
| <url type="homepage">http://codewith.mu/</url> | ||
| <url type="help">http://codewith.mu/tutorials/</url> | ||
| <url type="bugtracker">https://github.com/mu-editor/mu/issues</url> | ||
| <project_group>mu-editor</project_group> | ||
| <_developer_name>Nicholas H.Tollervey</_developer_name> | ||
| <x-developer_name>Nicholas H.Tollervey</x-developer_name> |
There was a problem hiding this comment.
This should just be developer_name, expect the _ was an accidental prefix
Pretends they weren't the one that wrote this....
ZanderBrown
approved these changes
Aug 25, 2018
Prefer over non-standard <x-developer_name/>
|
@knowledgejunkie you're on a roll! :-) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating the appdata with appstreamcli version 0.12.2 results in the following output:
$ appstreamcli validate conf/mu.appdata.xml
W - mu.appdata.xml:mu.codewith.editor.desktop:29
Found invalid tag: '_developer_name'. Non-standard tags must be prefixed with
"x-".
I - mu.appdata.xml:mu.codewith.editor.desktop:7
The component summary should not end with a "." [A simple Python editor for
beginner programmers.]
E - mu.appdata.xml:mu.codewith.editor.desktop:20
The description contains an URL. This is not allowed, please use the tag
to share links.
Validation failed: errors: 1, warnings: 1, infos: 1
This update corrects these issues