Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Adafruit mode to CircuitPython mode (Issue #835) #869

Merged
merged 13 commits into from
Jul 4, 2019
Merged

Rename Adafruit mode to CircuitPython mode (Issue #835) #869

merged 13 commits into from
Jul 4, 2019

Conversation

bwshockley
Copy link
Contributor

Some additional changes required to complete #835.

Renamed to circuitpython.py and changed file to be more universal covering all boards that support Circuit Python.
Added a generic Circuit Python image, Blinka, for the Circuit Python mode.
Reduced the comment section to under 79 characters.
Minor updates again.  Trying to determine why I keep getting an error about line 33 and 35 being too long.
@ntoll
Copy link
Member

ntoll commented Jun 28, 2019

I'll try getting this reviewed (and hopefully merged) over the weekend. Thanks!

Did you run the test suite..?

make check

Is what you need to do ;-)

@bwshockley
Copy link
Contributor Author

I got 2 warnings:
c:\users\shockleyb\appdata\local\programs\python\python37\lib\site-packages\parso\python\tree.py:46
c:\users\shockleyb\appdata\local\programs\python\python37\lib\site-packages\parso\python\tree.py:46: DeprecationWarning: Using or importing the ABCs from 'collections' instead of
from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Mapping

tests/interface/test_panes.py::test_JupyterREPLPane_init
c:\users\shockleyb\appdata\local\programs\python\python37\lib\site-packages\qtconsole\jupyter_widget.py:561: DeprecationWarning: JupyterREPLPane._style_sheet_changed is deprecated in traitlets 4.1: use @observe and @unobserve instead.
def _style_sheet_changed(self):

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this -- it looks good! We like your choice of image for the mode as well 😃

@carlosperate carlosperate changed the title New PR for Issue #835 Rename Adafruit mode to CircuitPython mode (Issue #835) Jul 2, 2019
Copy link
Member

@carlosperate carlosperate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @bwshockley!
I hope you don't mind I've changed the PR title for something a bit more descriptive.
I've also added a couple of comments to the PR, but they are very minor things.

mu/modes/circuitpython.py Outdated Show resolved Hide resolved
mu/modes/circuitpython.py Show resolved Hide resolved
mu/modes/circuitpython.py Outdated Show resolved Hide resolved
mu/modes/circuitpython.py Outdated Show resolved Hide resolved
Removed Mini SAM boards and ensured consistent usage of CircuitPython over Circuit Python.
@ntoll ntoll merged commit 4bfa077 into mu-editor:master Jul 4, 2019
@ntoll
Copy link
Member

ntoll commented Jul 4, 2019

@bwshockley thank you for doing this..! This is great to see... :-) I had to fix a couple of merge conflicts but it all looks good. It'll be in the upcoming alpha2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants