-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Adafruit mode to CircuitPython mode (Issue #835) #869
Conversation
Renamed to circuitpython.py and changed file to be more universal covering all boards that support Circuit Python.
Added a generic Circuit Python image, Blinka, for the Circuit Python mode.
Reduced the comment section to under 79 characters.
Minor updates again. Trying to determine why I keep getting an error about line 33 and 35 being too long.
|
I'll try getting this reviewed (and hopefully merged) over the weekend. Thanks! Did you run the test suite..?
Is what you need to do ;-) |
Minor change
|
I got 2 warnings: tests/interface/test_panes.py::test_JupyterREPLPane_init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this -- it looks good! We like your choice of image for the mode as well 😃
Additional, changed references to AdafruitMode to CircuitPythonMode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission @bwshockley!
I hope you don't mind I've changed the PR title for something a bit more descriptive.
I've also added a couple of comments to the PR, but they are very minor things.
Removed Mini SAM boards and ensured consistent usage of CircuitPython over Circuit Python.
|
@bwshockley thank you for doing this..! This is great to see... :-) I had to fix a couple of merge conflicts but it all looks good. It'll be in the upcoming alpha2 release. |
Some additional changes required to complete #835.