New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input min/max (and accidental indenting fix) #10

Merged
merged 4 commits into from Jul 8, 2015

Conversation

Projects
None yet
2 participants
@nkantar
Contributor

nkantar commented Jun 15, 2015

There could probably be better input validation based on the "too big"/"too many bombs" JS logic, but this is a start. :)

@muan

This comment has been minimized.

Owner

muan commented Jun 15, 2015

Cooool. Can you change the quotes to double quote instead of single quotes though? Thank you!

@nkantar

This comment has been minimized.

Contributor

nkantar commented Jun 16, 2015

@muan Oops, sorry, totally spazzed and didn't follow the project's conventions. Fixed now.

index.html Outdated
</div>
<div class="prepend-input">💣</div>
<input id="bombs" class="input" type="number" value="10">
<input id="bombs" class="input" type="number" value="10" min='1' max='500'>

This comment has been minimized.

@muan

muan Jun 16, 2015

Owner

Ooopppps also here. ;D

muan added a commit that referenced this pull request Jul 8, 2015

Merge pull request #10 from nkantar/gh-pages
Input min/max (and accidental indenting fix)

@muan muan merged commit 9e0b44f into muan:gh-pages Jul 8, 2015

@muan

This comment has been minimized.

Owner

muan commented Jul 8, 2015

belated but thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment