Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production usage support by configurable sampling function #45

Merged
merged 1 commit into from Oct 18, 2016

Conversation

@divyenduz
Copy link
Contributor

commented Sep 28, 2016

On high traffic websites, it is not ideal to sample each request via flask-profiler.
This commit provides an option to send a sampling function (provided by user) as configuration parameter.

If the sampling function returns True, sample is taken, if sampling function is not defined or returns False, sample is not taken.

README.md is also edited in this commit to give a couple of usage examples.

When merged, this will resolve issue #44

Divyendu Singh
Add production usage support by configurable sampling function
On high traffic websites, it is not ideal to sample each request via flask-profiler.
This commit provides an option to send a sampling function (provided by user)  as configuration parameter.

If the sampling function returns True, sample is taken, if sampling function is not defined or returns False, sample is not taken.

README.md is also edited in this commit to give a couple of usage examples.
@divyenduz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2016

@muatik : Let's discuss this when you get a chance. Would be lovely if we can merge this in October, I am participating in hacktoberfest 👍 👍

No hurries though if that is not possible.

Cheers,

@muatik muatik merged commit 113540f into muatik:master Oct 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@muatik

This comment has been minimized.

Copy link
Owner

commented Oct 18, 2016

I've already checked this pq, but somehow forget merging. :) now it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.