New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests with later versions of AssetPack (close #1 and #2) #3

Merged
merged 1 commit into from Oct 1, 2017

Conversation

Projects
None yet
2 participants
@jjatria
Contributor

jjatria commented Sep 30, 2017

As reported in #1 and #2, recent versions of the AssetPack plugin
would cause this plugin to fail with the message:

Loading DEPRECATED Mojolicious::Plugin::AssetPack::Backcompat.

Can't use string ("/css/angular-material.min.css") as an ARRAY ref

This patch fixes this by making some minor changes to the test suite
and the module itself:

  • Assets are now loaded using the ->process method. The registration
    is no longer conditional, since the condition was always true.

  • The AssetPack plugin is loaded with the Css and the JavaScript
    pipes when loading automatically. If the plugin is already loaded,
    the user configuration is respected.

  • The include test no longer uses the { inline => 1 } option, which
    seems to no longer work. Instead, it uses the example code present in
    the AssetPack documentation.

Fix failing tests with later versions of AssetPack
As reported in #1 and #2, recent versions of the AssetPack plugin
would cause this plugin to fail with the message:

> # Loading DEPRECATED Mojolicious::Plugin::AssetPack::Backcompat.
> Can't use string ("/css/angular-material.min.css") as an ARRAY ref

This patch fixes this by making some minor changes to the test suite
and the module itself:

* Assets are now loaded using the ->process method. The registration
  is no longer conditional, since the condition was always true.

* The AssetPack plugin is loaded with the Css and the JavaScript
  pipes when loading automatically. If the plugin is already loaded,
  the user configuration is respected.

* The include test no longer uses the `{ inline => 1 }` option, which
  seems to no longer work. Instead, it uses the example code present in
  the AssetPack documentation.

@mudler mudler merged commit 7e34c35 into mudler:master Oct 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mudler

This comment has been minimized.

Show comment
Hide comment
@mudler

mudler Oct 1, 2017

Owner

Thanks!

Owner

mudler commented Oct 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment