Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in natural grade aggregation for subcourses #29

Open
jjliaw opened this issue Dec 3, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jjliaw
Copy link

commented Dec 3, 2018

Hi David:

Thank you for this FANTASTIC plugin--this allows teachers to build robust learning modules and then use a master "dashboard" course to tie together the subcourses!

Wanted to a report a bug if any teachers use Natural Aggregation for grades (which is when a grade is simply the total of points earned divided by points possible)--the subcourse plugin does a great job of reporting back the points earned, EXCEPT if a teacher does a grade override to Exclude a grade for a student.

The actual subcourse calculates the grade correctly, but when it passes the grade to the "dashboard" course, the Subcourse plugin still pulls the Total Points possible without factoring in the lower grade total for any students with a teacher override to Exclude any grades for a student.

If you need screenshots I can upload them somewhere and share them.

Thank you for sharing this great plugin with the Moodle community!

@mudrd8mz

This comment has been minimized.

Copy link
Owner

commented Dec 3, 2018

Hi Joseph, and thanks for nice words about the plugin. I'll try to reproduce the steps you describe and will let you know.

@mudrd8mz

This comment has been minimized.

Copy link
Owner

commented Jan 15, 2019

Sorry, still did not get to this but it is on my radar. Meanwhile, step by step instructions to reproduce the problem (and what is the expected behaviour) will help. Thanks in advance!

@jjliaw

This comment has been minimized.

Copy link
Author

commented Feb 3, 2019

Hi David:

Thanks for your work on Subcourse--saw that you had a new release recently--thank you!

Here's how to reproduce the bug for calculating grades with Natural Aggregation:

  1. Setup a Test Subcourse and set the grading method to Natural Aggregation (a common method used by teachers where the grade is calculated by simply taking the total points earned divided by total points possible).

  2. Create a few assignments, and manually enter in some grades for test students, but do a grade override for a Test Student and Exclude an assignment. Note that within the subcourse, Moodle calculates the grade correctly using Natural Aggregation (for example, let's say you have 4 assignments each worth 25 points, and you exclude one of the assignments for a student due to illness, extenuating circumstances, etc. Now that student's grade will only be calculated out of 75 points.)

  3. In the "Master course", add in the Test Subcourse. Note that in the grade book, all of the students grades will be calculated accurately, except for the Test Student with the Excluded assignment--the Test Student should have their grade only calculated out of 75 points, but the Subcourse module will pass on the grade to be out of 100 points.

Thanks for looking into this and for sharing your great work with the Moodle community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.