New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make BeaconClock work with 3+ peers. Also added method from Te… #19

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@coreyker

coreyker commented Nov 2, 2018

…mpoClock to the FollowerClock.

@muellmusik

This comment has been minimized.

Owner

muellmusik commented Nov 5, 2018

Hi @coreyker, one small thing is that this PR combines two unrelated changes into one commit, which is not ideal. Commits should be clear and isolated so that you can easily revert a welcome change.

Sorry if that seems pedantic, but it could well help later. I can do a new PR if you like.

@coreyker

This comment has been minimized.

coreyker commented Nov 6, 2018

No problem. I made two new PRs

@coreyker coreyker closed this Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment