Permalink
Browse files

Simplified & sped up reloading of all thumbnails

  • Loading branch information...
muennich committed May 13, 2012
1 parent 4057453 commit d1a1e0142b453a7083463eaf02402b4d3b31ff65
Showing with 12 additions and 20 deletions.
  1. +1 −1 README.md
  2. +8 −16 commands.c
  3. +1 −1 commands.h
  4. +1 −1 config.def.h
  5. +1 −1 sxiv.1
View
@@ -93,7 +93,7 @@ The following general key commands are available:
A Toggle visibility of alpha-channel, i.e. transparency
r Reload image
- R Refresh thumbnails
+ R Reload all thumbnails
D Remove image from file list and go to next image
View
@@ -94,22 +94,14 @@ bool it_toggle_bar(arg_t a) {
return true;
}
-bool it_refresh_thumbs(arg_t a) {
- int i = 0;
- if (mode == MODE_THUMB) {
- win_set_cursor(&win, CURSOR_WATCH);
- while (i < filecnt) {
- if (!tns_load(&tns, i, &files[i], true, false)) {
- remove_file(i, false);
- tns.dirty = true;
- if (tns.sel >= tns.cnt)
- tns.sel = tns.cnt - 1;
- } else {
- i++;
- }
- }
- }
- return true;
+bool t_reload_all(arg_t a) {
+ if (mode == MODE_THUMB) {
+ tns_free(&tns);
+ tns_init(&tns, filecnt, &win);
+ return true;
+ } else {
+ return false;
+ }
}
bool it_reload_image(arg_t a) {
View
@@ -45,7 +45,7 @@ bool it_quit(arg_t);
bool it_switch_mode(arg_t);
bool it_toggle_fullscreen(arg_t);
bool it_toggle_bar(arg_t);
-bool it_refresh_thumbs(arg_t);
+bool t_reload_all(arg_t);
bool it_reload_image(arg_t);
bool it_remove_image(arg_t);
bool i_navigate(arg_t);
View
@@ -64,7 +64,7 @@ static const keymap_t keys[] = {
{ false, XK_b, it_toggle_bar, (arg_t) None },
{ false, XK_r, it_reload_image, (arg_t) None },
- { false, XK_R, it_refresh_thumbs, (arg_t) None },
+ { false, XK_R, t_reload_all, (arg_t) None },
{ false, XK_D, it_remove_image, (arg_t) None },
{ false, XK_n, i_navigate, (arg_t) +1 },
View
2 sxiv.1
@@ -118,7 +118,7 @@ Toggle visibility of alpha-channel, i.e. image transparency.
Reload image.
.TP
.B R
-Refresh thumbnails.
+Reload all thumbnails.
.TP
.B D
Remove current image from file list and go to next image.

2 comments on commit d1a1e01

Contributor

baskerville replied May 13, 2012

There's only a small drawback: tns.sel is lost.

Owner

muennich replied May 13, 2012

I know, but I prefer the visual feedback and the speed of the current solution. I might look into this further to come up with a solution to preserve the selection.

Please sign in to comment.