A non-image file which generates a segmentation fault #28

Closed
baskerville opened this Issue Nov 11, 2011 · 5 comments

Projects

None yet

2 participants

@baskerville
Contributor

Here it is:
http://cl.ly/Bjzz/clipfoo

To get into trouble, just run 'sxiv clipfoo'.

@muennich
Owner

I could not reproduce the segfault. It just displays nothing and prints wrong information in the title bar.

@muennich
Owner

Just tried feh on this file, it also displays nothing. Imlib2 detects the file as an image, so it's not a fault in sxiv.

@muennich muennich closed this Nov 11, 2011
@baskerville
Contributor

I could not reproduce the segfault. It just displays nothing and prints wrong information in the title bar.

Yes, with the default config.def.h it doesn't segfaults (is it
interpreted as an XPM?)

I compared my config.h with the default one and the first difference is:

#define EXIF_SUPPORT 1

It seems sufficient to produce the crash.

@muennich muennich added a commit that referenced this issue Nov 11, 2011
@muennich Fixed issue #28 92b2779
@baskerville
Contributor

Nice.
One remaining problem though: 'sxiv -t clipfoo' produces a segfault if EXIF support is enabled (and an error if it isn't).

@muennich muennich added a commit that referenced this issue Nov 13, 2011
@muennich Fixed issue #28 (again) ac4eb53
@muennich
Owner

With commit ac4eb53, images without a proper format string aren't opened anymore. I hope, that this won't break any valid images. It does fix all the issues with the "clipfoo" image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment