Some changes. #11

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Sep 12, 2011

File [Main.c] improved.
Use 0/1 instead of FALSE/TRUE.(Fastest)
Use Int Instead of Bool.(Fastest)
Add Unsigned/Short... keywords on function defination.
and...

GL. :)

Owner

muennich commented Sep 12, 2011

Some changes you've mentioned aren't there! No false/true got replaced with an int constant. And I wouldn't do it anyway, because I replaced all such occurences to booleans just recently, because I think this yields a much better readability.
Also, your patch breaks ANSI-C conformance (mixed code and declarations). There are a lot of empty lines added/removed, why? You've added some parentheses in conditional statements, why? I don't think, that the ternary operator is that much slower than if-else-statements. Why do you push such a cosmetic patch to me, if it doesn't adhere to the existing code style?

Sorry, but I will not pull this.

@muennich muennich closed this Sep 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment