Slideshow extensions #31

Closed
wants to merge 7 commits into
from

Projects

None yet

2 participants

@kurt-vd

I added some extensions:

  • screensaver disable & restore (with DPMS)
  • loop
  • control slideshow from commandline options
@kurt-vd

I used sxiv to show photo's on a party. Screensaver had to be turned off, & looping enabled.

@kurt-vd kurt-vd closed this Nov 19, 2011
@kurt-vd kurt-vd reopened this Nov 19, 2011
@kurt-vd

The DPMS restore function got lost for some reason.

@muennich
Owner

I will look into this later. After the first glance:

  • I want to change the looping to always loop when in slideshow
  • I want to put the start/stop slideshow actions into functions
  • I will not merge the last commit (config.h include control), because this file is only included once per compilation unit
  • I'm uncertain, wether screensaver/dpms control is really necessary, we could leave this to xset(1)
@kurt-vd

I want to change the looping to always loop when in slideshow
I think both policies have their use.
I didn't want to alter the normal behaviour.
I will not merge the last commit (config.h include control), because this file is only included once per compilation unit
The reason is that for DPMS control, I needed config.h in window.h ..., and every .c file
that includes config.h and window.h ...
A solution without include control exists, but is more difficult to maintain...
I'm uncertain, wether screensaver/dpms control is really necessary, we could leave this to xset(1)
I thought about this too.
IMHO scripting xset around sxiv is a bit difficult to restore the values afterwards. Doing
this from within sxiv seemed easier.
The latter has the advantage of being 'always in place', regardless of the user being smart enough
to do xset magic.
When toggling between slideshow & still image viewing, the xset solution around sxiv is inappropriate.
Calling xset from within sxiv seems a bit overkill to me.

@muennich
Owner

I removed the whole slideshow feature, because it's irrelevant to me. Sorry.

@muennich muennich closed this Feb 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment