New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desktop file and appropriate lines to Makefile. #50

Merged
merged 1 commit into from Apr 17, 2012

Conversation

Projects
None yet
3 participants
@barthalion
Contributor

barthalion commented Apr 17, 2012

According to the Arch Linux bugtracker, package maintainers are obliged to contact with upstream about adding .desktop files instead of adding it on their's own account.

I've commited the desktop file used in Arch' [community] repository and added some lines to Makefile to make use of it.

@barthalion

This comment has been minimized.

Contributor

barthalion commented Apr 17, 2012

Damn, I see small typo in Makefile. Please, do s/removind/removing/ :<

@xaizek

This comment has been minimized.

xaizek commented Apr 17, 2012

s/removind/removing/

@barthalion, FYI, you can do this yourself. Just make the change then run git commit -a --amend followed by git push --force (forcing is bad, but not in this case), and it's done.

@barthalion

This comment has been minimized.

Contributor

barthalion commented Apr 17, 2012

It will let me to edit last commit message, not the file itself AFAIK.

@xaizek

This comment has been minimized.

xaizek commented Apr 17, 2012

No, it will let you add changes to your commit (it adds all staged changes). You talking about the case when you don't run any git add commands. But if you pass -a key to git commit it will have affect of git add -u and all your changes in the working tree will be added to the last commit.

@muennich muennich merged commit 45f4f6d into muennich:master Apr 17, 2012

@muennich

This comment has been minimized.

Owner

muennich commented Apr 18, 2012

Please notice commit 56b6d23, with which the .desktop file is not installed automatically anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment