Latest commit(s) appears to have harmed XML syntax highlighting #25

Closed
bachya opened this Issue Apr 14, 2013 · 5 comments

Projects

None yet

2 participants

@bachya
bachya commented Apr 14, 2013

At some point during the last few commits, XML syntax highlighting appears to have partially broken. XML-style comments show as expected, but element names, attribute names, etc. don't.

Screen Shot 2013-04-13 at 10 21 14 PM

It appears that HTML is affected, as well.

@mugginsoft
Owner

Sorry about that.
I merged in a remote branch with a quite distant common ancestor,
This is a result of that.

I will resolve this today.

@bachya
bachya commented Apr 14, 2013

Thanks so much, Jonathan!

@mugginsoft
Owner

I think I have this fixed. I will check it out in the morning and hopefully commit it then.

@mugginsoft
Owner

I have pushed a fix for this. The merge was not to blame after all. Just a scanner in the main colouring loop not getting reset correctly.

Let me know if it looks okay.

What we really need here are some units tests that colour test input. I will put it on the todo list.

@bachya
bachya commented Apr 15, 2013

This worked; another issue arose, but I will put that in a separate ticket. Thanks, Jonathan!

@bachya bachya closed this Apr 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment